Skip to content

Commit 796c4a4

Browse files
DonJayamanneCopilot
andcommitted
fix: address SDK CI checks
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent f0a09d4 commit 796c4a4

4 files changed

Lines changed: 21 additions & 12 deletions

File tree

dotnet/test/Unit/ClientSessionLifetimeTests.cs

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -268,9 +268,10 @@ public async Task SessionRequests_Serialize_AdditionalDirectories()
268268
});
269269

270270
var createRequest = Assert.Single(server.Requests, request => request.Method == "session.create");
271-
Assert.Equal(
272-
new string?[] { "/repo/shared", "/repo/generated" },
273-
createRequest.Params.GetProperty("additionalDirectories").EnumerateArray().Select(value => value.GetString()));
271+
Assert.Collection(
272+
createRequest.Params.GetProperty("additionalDirectories").EnumerateArray(),
273+
value => Assert.Equal("/repo/shared", value.GetString()),
274+
value => Assert.Equal("/repo/generated", value.GetString()));
274275

275276
server.ClearRequests();
276277

@@ -281,9 +282,9 @@ public async Task SessionRequests_Serialize_AdditionalDirectories()
281282
});
282283

283284
var resumeRequest = Assert.Single(server.Requests, request => request.Method == "session.resume");
284-
Assert.Equal(
285-
new string?[] { "/repo/resumed" },
286-
resumeRequest.Params.GetProperty("additionalDirectories").EnumerateArray().Select(value => value.GetString()));
285+
Assert.Collection(
286+
resumeRequest.Params.GetProperty("additionalDirectories").EnumerateArray(),
287+
value => Assert.Equal("/repo/resumed", value.GetString()));
287288
}
288289

289290
[Fact]

java/src/main/java/com/github/copilot/rpc/CreateSessionRequest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,12 @@ public List<String> getAdditionalDirectories() {
500500
return additionalDirectories;
501501
}
502502

503-
/** Sets additional directories. @param additionalDirectories the additional directories */
503+
/**
504+
* Sets additional directories.
505+
*
506+
* @param additionalDirectories
507+
* the additional directories
508+
*/
504509
public void setAdditionalDirectories(List<String> additionalDirectories) {
505510
this.additionalDirectories = additionalDirectories;
506511
}

java/src/main/java/com/github/copilot/rpc/ResumeSessionRequest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,12 @@ public List<String> getAdditionalDirectories() {
505505
return additionalDirectories;
506506
}
507507

508-
/** Sets additional directories. @param additionalDirectories the additional directories */
508+
/**
509+
* Sets additional directories.
510+
*
511+
* @param additionalDirectories
512+
* the additional directories
513+
*/
509514
public void setAdditionalDirectories(List<String> additionalDirectories) {
510515
this.additionalDirectories = additionalDirectories;
511516
}

java/src/test/java/com/github/copilot/SessionRequestBuilderTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,7 @@ void testBuildCreateRequestSetsClientName() {
9797

9898
@Test
9999
void testBuildCreateRequestSetsAdditionalDirectories() {
100-
var config = new SessionConfig()
101-
.setAdditionalDirectories(List.of("/repo/shared", "/repo/generated"));
100+
var config = new SessionConfig().setAdditionalDirectories(List.of("/repo/shared", "/repo/generated"));
102101
CreateSessionRequest request = SessionRequestBuilder.buildCreateRequest(config);
103102
assertEquals(List.of("/repo/shared", "/repo/generated"), request.getAdditionalDirectories());
104103
}
@@ -300,8 +299,7 @@ void testBuildResumeRequestSetsClientName() {
300299
@Test
301300
void testBuildResumeRequestSetsAdditionalDirectories() {
302301
var config = new ResumeSessionConfig().setAdditionalDirectories(List.of("/repo/resumed"));
303-
ResumeSessionRequest request = SessionRequestBuilder.buildResumeRequest("sid-additional-directories",
304-
config);
302+
ResumeSessionRequest request = SessionRequestBuilder.buildResumeRequest("sid-additional-directories", config);
305303
assertEquals(List.of("/repo/resumed"), request.getAdditionalDirectories());
306304
}
307305

0 commit comments

Comments
 (0)