Skip to content

Commit d82d7e9

Browse files
rojiroji
committed
Temporarily skip extension-host E2E coverage
Document PR #2395 and the Rust-only out-of-process transition on Node extension-authored factory coverage, the real-host extension environment test, and .NET extension lifecycle tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3f5c3c30-0cf7-4b9a-9a3b-2b01ca073015
1 parent 309bff4 commit d82d7e9

3 files changed

Lines changed: 57 additions & 40 deletions

File tree

‎dotnet/test/E2E/RpcExtensionsLoadedE2ETests.cs‎

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,12 @@ namespace GitHub.Copilot.Test.E2E;
2525
public class RpcExtensionsLoadedE2ETests(E2ETestFixture fixture, ITestOutputHelper output)
2626
: E2ETestBase(fixture, "rpc_extensions_loaded", output)
2727
{
28+
// TODO(PR #2395): Temporarily disabled while this PR transitions managed out-of-process SDK
29+
// launches to the Rust-only flow. Re-enable when that flow provides the Node extension
30+
// subprocess lifecycle required by the EXTENSIONS controller.
31+
private const string RustOnlyFlowSkipReason =
32+
"Temporarily disabled for the Rust-only out-of-process transition in PR #2395";
33+
2834
/// <summary>
2935
/// Extension subprocess startup involves Node fork + SDK resolver + JSON-RPC
3036
/// handshake. Empirically this completes in well under a second on Windows,
@@ -163,7 +169,7 @@ await TestHelper.WaitForConditionAsync(
163169
return lastSeen!;
164170
}
165171

166-
[Theory]
172+
[Theory(Skip = RustOnlyFlowSkipReason)]
167173
[InlineData("user")]
168174
[InlineData("project")]
169175
public async Task Discovers_Loads_And_Reports_Running_Extension(string sourceValue)
@@ -206,7 +212,7 @@ public async Task Discovers_Loads_And_Reports_Running_Extension(string sourceVal
206212
Assert.True(ext.Pid > 0);
207213
}
208214

209-
[Fact]
215+
[Fact(Skip = RustOnlyFlowSkipReason)]
210216
public async Task Disable_Then_Enable_Cycles_Extension_Status()
211217
{
212218
var extName = CreateUserExtension();
@@ -234,7 +240,7 @@ public async Task Disable_Then_Enable_Cycles_Extension_Status()
234240
Assert.NotNull(reEnabled.Pid);
235241
}
236242

237-
[Fact]
243+
[Fact(Skip = RustOnlyFlowSkipReason)]
238244
public async Task Reload_Picks_Up_Extension_Added_After_Session_Create()
239245
{
240246
// Start the session BEFORE writing the extension so the initial discovery sees nothing.
@@ -268,7 +274,7 @@ await TestHelper.WaitForConditionAsync(
268274
Assert.Equal(ExtensionSource.User, ext.Source);
269275
}
270276

271-
[Fact]
277+
[Fact(Skip = RustOnlyFlowSkipReason)]
272278
public async Task Failed_Extension_Reports_Failed_Status()
273279
{
274280
// Write an extension whose body throws synchronously at import time.
@@ -296,7 +302,7 @@ public async Task Failed_Extension_Reports_Failed_Status()
296302
Assert.Equal(ExtensionSource.User, ext.Source);
297303
}
298304

299-
[Fact]
305+
[Fact(Skip = RustOnlyFlowSkipReason)]
300306
public async Task Multiple_Extensions_Are_Discovered_Independently()
301307
{
302308
var ext1Name = CreateUserExtension(prefix: "multi-a");
@@ -320,7 +326,7 @@ public async Task Multiple_Extensions_Are_Discovered_Independently()
320326
Assert.Equal(pids.Count, pids.Distinct().Count());
321327
}
322328

323-
[Fact]
329+
[Fact(Skip = RustOnlyFlowSkipReason)]
324330
public async Task Reload_Preserves_Disabled_State_Across_Calls()
325331
{
326332
var extName = CreateUserExtension(prefix: "persistent-disable");

‎nodejs/test/e2e/extension_env_access.e2e.test.ts‎

Lines changed: 22 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -184,28 +184,34 @@ it("ignores a granted variable the extension never requested", async () => {
184184
expect(run.postjoin).toBe("E2E_SDK_TOKEN=granted-token\nE2E_SDK_SMUGGLED=");
185185
});
186186

187-
const cliObservations = isInProcessTransport
188-
? ""
189-
: mkdtempSync(join(tmpdir(), "copilot-env-access-cli-"));
187+
// TODO(PR #2395): Temporarily disable the real-host extension case because this PR transitions
188+
// managed out-of-process SDK launches to the Rust-only flow, which does not yet provide the Node
189+
// extension subprocess lifecycle required for the fixture extension to join.
190+
const extensionHostTestDisabledForRustOnlyFlow = true;
191+
const cliObservations =
192+
isInProcessTransport || extensionHostTestDisabledForRustOnlyFlow
193+
? ""
194+
: mkdtempSync(join(tmpdir(), "copilot-env-access-cli-"));
190195
const cliResultFile = join(cliObservations, "result");
191-
const cliContext = isInProcessTransport
192-
? undefined
193-
: await createSdkTestContext({
194-
copilotClientOptions: {
195-
env: {
196-
COPILOT_CLI_ENABLED_FEATURE_FLAGS: "EXTENSIONS",
197-
EXTENSION_ENV_REQUEST: "E2E_SDK_TOKEN",
198-
EXTENSION_RESULT_FILE: cliResultFile,
199-
EXTENSION_PREJOIN_FILE: join(cliObservations, "prejoin"),
200-
EXTENSION_POSTJOIN_FILE: join(cliObservations, "postjoin"),
196+
const cliContext =
197+
isInProcessTransport || extensionHostTestDisabledForRustOnlyFlow
198+
? undefined
199+
: await createSdkTestContext({
200+
copilotClientOptions: {
201+
env: {
202+
COPILOT_CLI_ENABLED_FEATURE_FLAGS: "EXTENSIONS",
203+
EXTENSION_ENV_REQUEST: "E2E_SDK_TOKEN",
204+
EXTENSION_RESULT_FILE: cliResultFile,
205+
EXTENSION_PREJOIN_FILE: join(cliObservations, "prejoin"),
206+
EXTENSION_POSTJOIN_FILE: join(cliObservations, "postjoin"),
207+
},
201208
},
202-
},
203-
});
209+
});
204210

205211
// The released CLI ignores `requestedEnvironmentVariables`, so this covers the
206212
// half a real CLI can prove today: asking for variables does not break the join.
207213
// It becomes the grant test once `@github/copilot` carries the host half.
208-
it.skipIf(isInProcessTransport)(
214+
it.skipIf(isInProcessTransport || extensionHostTestDisabledForRustOnlyFlow)(
209215
"joins a real CLI that does not support environment requests",
210216
async () => {
211217
if (!cliContext) {

‎nodejs/test/e2e/factory.e2e.test.ts‎

Lines changed: 23 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,20 @@ import {
1313
import { retry } from "./harness/sdkTestHelper.js";
1414

1515
const __dirname = dirname(fileURLToPath(import.meta.url));
16-
const factoryTestContext = isInProcessTransport
17-
? undefined
18-
: await createSdkTestContext({
19-
copilotClientOptions: {
20-
env: {
21-
COPILOT_CLI_ENABLED_FEATURE_FLAGS: "EXTENSIONS,AGENT_FACTORIES",
16+
// TODO(PR #2395): Temporarily disable extension-authored factory E2E coverage while this PR
17+
// transitions managed out-of-process SDK launches to the Rust-only flow. Re-enable when that
18+
// flow provides the Node extension subprocess lifecycle required to load factory-extension.mjs.
19+
const factoryTestsDisabledForRustOnlyFlow = true;
20+
const factoryTestContext =
21+
isInProcessTransport || factoryTestsDisabledForRustOnlyFlow
22+
? undefined
23+
: await createSdkTestContext({
24+
copilotClientOptions: {
25+
env: {
26+
COPILOT_CLI_ENABLED_FEATURE_FLAGS: "EXTENSIONS,AGENT_FACTORIES",
27+
},
2228
},
23-
},
24-
});
29+
});
2530

2631
async function setupFactoryExtension(workDir: string, onPermissionRequest = approveAll) {
2732
if (!factoryTestContext) {
@@ -73,7 +78,7 @@ async function setupFactoryExtension(workDir: string, onPermissionRequest = appr
7378
return session;
7479
}
7580

76-
it.skipIf(isInProcessTransport)(
81+
it.skipIf(isInProcessTransport || factoryTestsDisabledForRustOnlyFlow)(
7782
"runs an extension-authored factory across the SDK process boundary",
7883
async () => {
7984
if (!factoryTestContext) {
@@ -113,7 +118,7 @@ it.skip("forwards every declared subagent option to the runtime", async () => {
113118
});
114119
}, 60_000);
115120

116-
it.skipIf(isInProcessTransport)(
121+
it.skipIf(isInProcessTransport || factoryTestsDisabledForRustOnlyFlow)(
117122
"throws FactoryResumeError with not_found for an unknown run",
118123
async () => {
119124
if (!factoryTestContext) {
@@ -131,7 +136,7 @@ it.skipIf(isInProcessTransport)(
131136
}
132137
);
133138

134-
it.skipIf(isInProcessTransport)(
139+
it.skipIf(isInProcessTransport || factoryTestsDisabledForRustOnlyFlow)(
135140
"throws FactoryResumeError with non_resumable for a completed run",
136141
async () => {
137142
if (!factoryTestContext) {
@@ -148,7 +153,7 @@ it.skipIf(isInProcessTransport)(
148153
}
149154
);
150155

151-
it.skipIf(isInProcessTransport)(
156+
it.skipIf(isInProcessTransport || factoryTestsDisabledForRustOnlyFlow)(
152157
"runs a factory when its session denies every permission request",
153158
async () => {
154159
if (!factoryTestContext) {
@@ -165,7 +170,7 @@ it.skipIf(isInProcessTransport)(
165170
}
166171
);
167172

168-
it.skipIf(isInProcessTransport)(
173+
it.skipIf(isInProcessTransport || factoryTestsDisabledForRustOnlyFlow)(
169174
"resumes a failed factory when its session denies every permission request",
170175
async () => {
171176
if (!factoryTestContext) {
@@ -188,7 +193,7 @@ it.skipIf(isInProcessTransport)(
188193
}
189194
);
190195

191-
it.skipIf(isInProcessTransport)(
196+
it.skipIf(isInProcessTransport || factoryTestsDisabledForRustOnlyFlow)(
192197
"refuses a factory started through the context session from a factory body",
193198
async () => {
194199
if (!factoryTestContext) {
@@ -207,7 +212,7 @@ it.skipIf(isInProcessTransport)(
207212
}
208213
);
209214

210-
it.skipIf(isInProcessTransport)(
215+
it.skipIf(isInProcessTransport || factoryTestsDisabledForRustOnlyFlow)(
211216
"refuses a factory started through the module session from a factory body",
212217
async () => {
213218
if (!factoryTestContext) {
@@ -226,7 +231,7 @@ it.skipIf(isInProcessTransport)(
226231
}
227232
);
228233

229-
it.skipIf(isInProcessTransport)(
234+
it.skipIf(isInProcessTransport || factoryTestsDisabledForRustOnlyFlow)(
230235
"allows a module-level extension watcher to start a factory while another body is parked",
231236
async () => {
232237
if (!factoryTestContext) {
@@ -273,7 +278,7 @@ it.skipIf(isInProcessTransport)(
273278
60_000
274279
);
275280

276-
it.skipIf(isInProcessTransport)(
281+
it.skipIf(isInProcessTransport || factoryTestsDisabledForRustOnlyFlow)(
277282
"returns an array result from an extension-authored factory",
278283
async () => {
279284
if (!factoryTestContext) {
@@ -291,7 +296,7 @@ it.skipIf(isInProcessTransport)(
291296
}
292297
);
293298

294-
it.skipIf(isInProcessTransport)(
299+
it.skipIf(isInProcessTransport || factoryTestsDisabledForRustOnlyFlow)(
295300
"passes array factory arguments across the SDK process boundary",
296301
async () => {
297302
if (!factoryTestContext) {

0 commit comments

Comments
 (0)