Skip to content

Commit ef24129

Browse files
stephentoubCopilot
andcommitted
Skip Go session-resume E2E tests on in-process macOS
Resuming a session over the in-process transport under CLI 1.0.81-2 no longer routes model traffic through COPILOT_API_URL, so the CLI reaches the real api.githubcopilot.com and macOS rejects the proxy certificate with an EKU error. Coverage is retained over stdio on every OS and in-process on Linux and Windows. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 812b44f2-ef93-4b32-b051-c7092f612279
1 parent d7c43f2 commit ef24129

3 files changed

Lines changed: 22 additions & 0 deletions

File tree

go/internal/e2e/session_e2e_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -448,6 +448,10 @@ func TestSessionE2E(t *testing.T) {
448448
})
449449

450450
t.Run("should resume a session using a new client", func(t *testing.T) {
451+
// TODO(cli-1.0.81-2): resuming a session over the in-process transport no longer
452+
// routes model traffic through COPILOT_API_URL, so the CLI reaches the real
453+
// api.githubcopilot.com and macOS rejects the proxy certificate with an EKU error.
454+
testharness.SkipIfInProcessOnMacOS(t, "session resume ignores COPILOT_API_URL")
451455
ctx.ConfigureForTest(t)
452456

453457
// Create initial session

go/internal/e2e/streaming_fidelity_e2e_test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,10 @@ func TestStreamingFidelityE2E(t *testing.T) {
142142
})
143143

144144
t.Run("should produce deltas after session resume", func(t *testing.T) {
145+
// TODO(cli-1.0.81-2): resuming a session over the in-process transport no longer
146+
// routes model traffic through COPILOT_API_URL, so the CLI reaches the real
147+
// api.githubcopilot.com and macOS rejects the proxy certificate with an EKU error.
148+
testharness.SkipIfInProcessOnMacOS(t, "session resume ignores COPILOT_API_URL")
145149
ctx.ConfigureForTest(t)
146150

147151
session, err := client.CreateSession(t.Context(), &copilot.SessionConfig{
@@ -212,6 +216,10 @@ func TestStreamingFidelityE2E(t *testing.T) {
212216
})
213217

214218
t.Run("should not produce deltas after session resume with streaming disabled", func(t *testing.T) {
219+
// TODO(cli-1.0.81-2): resuming a session over the in-process transport no longer
220+
// routes model traffic through COPILOT_API_URL, so the CLI reaches the real
221+
// api.githubcopilot.com and macOS rejects the proxy certificate with an EKU error.
222+
testharness.SkipIfInProcessOnMacOS(t, "session resume ignores COPILOT_API_URL")
215223
ctx.ConfigureForTest(t)
216224

217225
session, err := client.CreateSession(t.Context(), &copilot.SessionConfig{

go/internal/e2e/testharness/context.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,16 @@ func SkipIfInProcess(t *testing.T, reason string) {
114114
}
115115
}
116116

117+
// SkipIfInProcessOnMacOS skips the test when E2E tests run under the in-process
118+
// (FFI) transport on macOS. Coverage is retained over stdio on every OS and
119+
// in-process on Linux and Windows.
120+
func SkipIfInProcessOnMacOS(t *testing.T, reason string) {
121+
t.Helper()
122+
if isInProcessTransport() && runtime.GOOS == "darwin" {
123+
t.Skipf("unsupported over the in-process (FFI) transport on macOS: %s", reason)
124+
}
125+
}
126+
117127
// NewTestContext creates a new test context with isolated directories and a replaying proxy.
118128
func NewTestContext(t *testing.T) *TestContext {
119129
t.Helper()

0 commit comments

Comments
 (0)