Skip to content

Commit f0a9187

Browse files
stephentoubCopilot
andcommitted
Limit re-enabled Node coverage
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent a4d0706 commit f0a9187

2 files changed

Lines changed: 18 additions & 17 deletions

File tree

nodejs/test/e2e/factory.e2e.test.ts

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -93,26 +93,25 @@ it.skipIf(isInProcessTransport)(
9393
}
9494
);
9595

96+
// TODO(cli-1.0.81-2): the subagent request is rejected downstream under CLI 1.0.81-2, so the
97+
// fixture reports didThrow: true. Re-enable once the runtime fix ships.
98+
//
9699
// The timeout is generous because the factory abandons its subagent once the runtime has
97100
// accepted the request, so the run settles only after the runtime drains that work.
98-
it.skipIf(isInProcessTransport)(
99-
"forwards every declared subagent option to the runtime",
100-
async () => {
101-
if (!factoryTestContext) {
102-
throw new Error("Factory E2E requires the stdio transport");
103-
}
104-
const { workDir } = factoryTestContext;
105-
await using session = await setupFactoryExtension(workDir);
101+
it.skip("forwards every declared subagent option to the runtime", async () => {
102+
if (!factoryTestContext) {
103+
throw new Error("Factory E2E requires the stdio transport");
104+
}
105+
const { workDir } = factoryTestContext;
106+
await using session = await setupFactoryExtension(workDir);
106107

107-
const result = await session.factory.run("forwards-subagent-options");
108+
const result = await session.factory.run("forwards-subagent-options");
108109

109-
expect(result).toMatchObject({
110-
status: "completed",
111-
result: { didThrow: false },
112-
});
113-
},
114-
60_000
115-
);
110+
expect(result).toMatchObject({
111+
status: "completed",
112+
result: { didThrow: false },
113+
});
114+
}, 60_000);
116115

117116
it.skipIf(isInProcessTransport)(
118117
"throws FactoryResumeError with not_found for an unknown run",

nodejs/test/e2e/rpc_ui_ephemeral_query.e2e.test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ import { createSdkTestContext, isInProcessTransport } from "./harness/sdkTestCon
99
describe("UI ephemeral query RPC", async () => {
1010
const { copilotClient: client } = await createSdkTestContext();
1111

12-
it.skipIf(isInProcessTransport)(
12+
// TODO(cli-1.0.81-2): CLI 1.0.81-6 still fails session.ui.ephemeralQuery against the
13+
// recorded snapshot on macOS ("Failed to get response from the AI model").
14+
it.skipIf(isInProcessTransport || process.platform === "darwin")(
1315
"should answer ephemeral query",
1416
{ timeout: 120_000 },
1517
async () => {

0 commit comments

Comments
 (0)