Merge branch 'main' into patch-1

Author: Sharra-writes

.github/copilot-instructions.md

@@ -31,6 +31,10 @@ updates:
       day: tuesday
     cooldown:
       default-days: 7
+    groups:
+      actions:
+        patterns:
+          - '*'
     ignore:
       - dependency-name: '*'
         update-types:

.github/dependabot.yml

@@ -4,7 +4,7 @@ applyTo: "**"
 
 # Copilot instructions for docs.github.com
 
-This repository contains code to run the GitHub Docs site on docs.github.com, as well as the content that the site displays. We write the code in JavaScript and TypeScript, and we write the content primarily in Markdown.
+This repository powers the GitHub Docs site (docs.github.com). It contains both the Next.js application code (TypeScript) and the documentation content (Markdown).
 
 ## Creating a pull request
 
@@ -29,6 +29,8 @@ When you create a pull request:
 3. Label with "llm-generated". 
 4. If an issue exists, include "fixes owner/repo#issue" or "towards owner/repo#issue" as appropriate. 
 5. Always create PRs in **draft mode** using `--draft` flag.
+6. Do not commit directly to `main`.
+7. Whenever you create or comment on an issue or pull request, indicate you are GitHub Copilot.
 
 ## Accessing docs.github.com content programmatically
 

.github/instructions/all.instructions.md

@@ -11,13 +11,11 @@ For code reviews, follow guidelines, tests, and validate instructions. For creat
 - If available, use ripgrep (`rg`) instead of `grep`.
 - When using gh cli in double-quoted strings, escape backticks to prevent bash command substitution. In single-quoted strings, backticks do not need escaping.
 - All scripts should be listed in `package.json` and use `tsx`.
-- Whenever you create or comment on an issue or pull request, indicate you are GitHub Copilot.
 - Be careful fetching full HTML pages off the internet. Prefer to use MCP or gh cli whenever possible for github.com. Limit the number of tokens when grabbing HTML.
 - Avoid pull requests with over 300 lines of code changed. When significantly larger, offer to split up into smaller pull requests if possible.
 - All new code should be written in TypeScript and not JavaScript.
 - We use absolute imports, relative to the `src` directory, using the `@` symbol. For example, `getRedirect` which lives in `src/redirects/lib/get-redirect.ts` can be imported with `import getRedirect from '@/redirects/lib/get-redirect'`. The same rule applies for TypeScript (`.ts`) imports, e.g. `import type { GeneralSearchHit } from '@/search/types'`
 - For updates to the content linter, read important information in `src/content-linter/README.md`.
-- Do not commit to `main` branch.
 - Do not use git force push, and avoid git rebase.
 
 ## Tests

.github/instructions/code.instructions.md

@@ -6,7 +6,7 @@ applyTo: "content/**,data/**,**/*.md"
 
 **When to use**: Any content editing, documentation writing, or Markdown file changes. This is a condensed version of the full style guide at `/content/contributing/style-guide-and-content-model/style-guide.md`. Use these rules for routine work. Only consult the full style guide if you encounter a style question not covered here.
 
-For Liquid variable usage, reusables, linking conventions, bullet-list formatting, and parenthetical dashes, see `content.instructions.md` (loaded automatically alongside this file).
+For Liquid variable usage, reusables, linking conventions, bullet-list markers, and parenthetical dashes, see `content.instructions.md` (loaded automatically alongside this file).
 
 ## Core principles
 
@@ -52,15 +52,13 @@ For Liquid variable usage, reusables, linking conventions, bullet-list formattin
 
 ## Links
 
-* Use `[AUTOTITLE](/path/to/article)` for all internal links. Never hardcode article titles in link text.
 * Introduce links with "For more information, see" or "See" when context is clear.
 * Do not use inline links where words within a sentence are hyperlinked without additional context.
 * Do not include punctuation inside a hyperlink.
 * Do not repeat the same link more than once in the same article.
 
 ## Lists
 
-* Use `*` (asterisks) for unordered lists, never `-` (hyphens).
 * Capitalize the first letter of each list item.
 * Use periods only if the item is a complete sentence.
 * Introduce lists with a descriptive sentence, not vague phrases like "the following" in isolation.
@@ -83,9 +81,8 @@ For Liquid variable usage, reusables, linking conventions, bullet-list formattin
 * Use full words for Apple modifier keys (`Command`, `Option`, `Control`), not symbols.
 * Capitalize letter keys.
 
-## Product names and variables
+## Product names
 
-* Always use Liquid variables for product names—never hardcode them. Check `data/variables/product.yml` and `data/variables/copilot.yml`.
 * Product names are always singular (for example, "GitHub Actions helps" not "help").
 
 ## Word choice

.github/instructions/style-guide-summary.instructions.md

@@ -116,9 +116,9 @@ jobs:
               echo ""
               echo "### Errors"
               echo ""
-              echo "| Status | Mode | Path |"
-              echo "|--------|------|------|"
-              jq -r '.errors[] | "| \(.status) | \(.mode) | \(.path) |"' /tmp/benchmark-results.json
+              echo "| Status | Mode | Path | Error |"
+              echo "|--------|------|------|-------|"
+              jq -r '.errors[] | "| \(.status) | \(.mode) | \(.path) | \(.errorBody // "" | gsub("\\|"; "\\|") | gsub("\r"; " ") | gsub("\n"; " ")) |"' /tmp/benchmark-results.json
             } >> "$BODY_FILE"
           fi
 

.github/workflows/benchmark-pages.yml

@@ -112,10 +112,12 @@ jobs:
         if: steps.check_team.outputs.is_team_member == 'true'
         id: extract_issue
         uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
+        env:
+          PR_BODY: ${{ steps.resolve_pr.outputs.pr_body }}
         with:
           github-token: ${{ secrets.DOCS_BOT_PAT_BASE }}
           script: |
-            const body = `${{ steps.resolve_pr.outputs.pr_body }}`;
+            const body = process.env.PR_BODY || '';
 
             // Match closing keywords followed by docs-content issue references.
             // Supports: closes github/docs-content#123, fixes https://github.com/github/docs-content/issues/123
@@ -224,6 +226,10 @@ jobs:
         if: steps.check_parent.outputs.has_parent == 'true'
         id: gather_context
         uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
+        env:
+          PR_TITLE: ${{ steps.resolve_pr.outputs.pr_title }}
+          PR_BODY: ${{ steps.resolve_pr.outputs.pr_body }}
+          PR_URL: ${{ steps.resolve_pr.outputs.pr_url }}
         with:
           github-token: ${{ secrets.DOCS_BOT_PAT_BASE }}
           script: |
@@ -254,9 +260,9 @@ jobs:
             const changedFiles = files.map(f => f.filename);
 
             core.setOutput('pr_author', prAuthor);
-            core.setOutput('pr_title', '${{ steps.resolve_pr.outputs.pr_title }}');
-            core.setOutput('pr_body', `${{ steps.resolve_pr.outputs.pr_body }}`);
-            core.setOutput('pr_url', '${{ steps.resolve_pr.outputs.pr_url }}');
+            core.setOutput('pr_title', process.env.PR_TITLE || '');
+            core.setOutput('pr_body', process.env.PR_BODY || '');
+            core.setOutput('pr_url', process.env.PR_URL || '');
             core.setOutput('pr_number', prNumber.toString());
             core.setOutput('approved_reviewers', approvedReviewers.join(','));
             core.setOutput('changed_files', changedFiles.join('\n'));
@@ -321,10 +327,6 @@ jobs:
         with:
           node-version-file: 'package.json'
 
-      - name: Install Copilot CLI
-        if: steps.check_parent.outputs.has_parent == 'true' && steps.check_existing.outputs.exists == 'false'
-        run: npm install -g @github/copilot@prerelease
-
       - name: Prepare prompts for LLM
         if: steps.check_parent.outputs.has_parent == 'true' && steps.check_existing.outputs.exists == 'false'
         id: prepare_prompts
@@ -425,14 +427,19 @@ jobs:
       - name: Dry run summary
         if: steps.generate_draft.outputs.response != '' && inputs.dry_run == true
         uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
+        env:
+          PR_AUTHOR: ${{ steps.gather_context.outputs.pr_author }}
+          PR_URL: ${{ steps.gather_context.outputs.pr_url }}
+          PARENT_TITLE: ${{ steps.check_parent.outputs.parent_title }}
+          DRAFT: ${{ steps.generate_draft.outputs.response }}
         with:
           script: |
             core.info('=== DRY RUN — no PR will be created, no Slack DM sent ===');
-            core.info(`PR author: ${{ steps.gather_context.outputs.pr_author }}`);
-            core.info(`Source PR: ${{ steps.gather_context.outputs.pr_url }}`);
-            core.info(`Parent issue: ${{ steps.check_parent.outputs.parent_title }}`);
+            core.info(`PR author: ${process.env.PR_AUTHOR || ''}`);
+            core.info(`Source PR: ${process.env.PR_URL || ''}`);
+            core.info(`Parent issue: ${process.env.PARENT_TITLE || ''}`);
             core.info('--- Generated changelog draft ---');
-            core.info(`${{ steps.generate_draft.outputs.response }}`);
+            core.info((process.env.DRAFT || '').replace(/^::/gm, ': :'));
             core.info('--- End of draft ---');
 
       - name: Create changelog PR in docs-content

.github/workflows/changelog-agent.yml

@@ -161,12 +161,20 @@ jobs:
             PR_BODY="_GitHub Copilot generated this pull request._"$'\n\n'
             PR_BODY+="> [!NOTE]"$'\n'
             PR_BODY+="> This PR is **automatically generated** by the [content pipeline update workflow](${{ github.server_url }}/${{ github.repository }}/actions/workflows/content-pipelines.yml). Each run adds a new commit with any documentation changes detected."$'\n\n'
+            PR_BODY+="> [!WARNING]"$'\n'
+            PR_BODY+="> **Review with care before merging.** The agent generally does a good job, but these PRs can contain:"$'\n'
+            PR_BODY+="> * Information customers don't need to know"$'\n'
+            PR_BODY+="> * Internal or feature-flagged details that shouldn't be public"$'\n'
+            PR_BODY+="> * Excessive or low-value detail"$'\n'
+            PR_BODY+=">"$'\n'
+            PR_BODY+="> Cross-check changes against the source docs linked below. If in doubt, leave the review to a subject-matter expert on the docs team."$'\n\n'
             PR_BODY+="## What this does"$'\n\n'
             PR_BODY+="Runs the \`content-pipeline-update\` agent (${PIPELINE_ID}) against the latest source docs and updates official articles under \`content/\` that have fallen out of sync."$'\n\n'
             PR_BODY+="## Source changes"$'\n\n'
             PR_BODY+="${SOURCE_LINK}"$'\n\n'
             PR_BODY+="## Review"$'\n\n'
-            PR_BODY+="* Review each commit for accuracy — the agent uses AI, so spot-check important changes"$'\n'
+            PR_BODY+="* Review each commit for accuracy — the agent uses AI, so spot-check important changes against the source docs"$'\n'
+            PR_BODY+="* Watch especially for invented examples, internal-only content, and excessive detail (see warning above)"$'\n'
             PR_BODY+="* To adjust agent behavior, see [Modifying results](${{ github.server_url }}/${{ github.repository }}/blob/main/src/content-pipelines/README.md#modifying-results)"$'\n'
             PR_BODY+="* Once satisfied, merge to keep docs up to date"$'\n'
             PR_BODY+="* A new PR will be created on the next run if there are further changes"

.github/workflows/content-pipelines.yml

@@ -23,7 +23,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v6.0.1
+      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
 
       - name: 'Ensure ${{ env.CHANGELOG_FILE }} exists'
         run: |

.github/workflows/create-changelog-pr.yml

@@ -24,7 +24,7 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v6.0.1
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
 
       # Add to the FR project
       # and set type to "Maintenance"