Fix temporary ID substitution in safe-output comments #12072
cjs.yml
on: pull_request
checkout-cache
19s
Matrix: js-tests
js-typecheck
41s
impacted-js-tests
38s
lint-js
1m 22s
Artifact API Integration
32s
Cleanup checkout cache
4s
Annotations
1 error and 10 warnings
|
Cleanup checkout cache
Process completed with exit code 1.
|
|
lint-js:
actions/setup/js/create_files.cjs#L112
Wrap fs.realpathSync(directoryPath) in try/catch — realpathSync throws on missing paths, permission denied, or symlink cycles; without a call-site try/catch, you lose the original error context and get a generic engine-level stack instead of a specific message with `{ cause }`
|
|
lint-js:
actions/setup/js/create_files.cjs#L104
Wrap fs.realpathSync(root) in try/catch — realpathSync throws on missing paths, permission denied, or symlink cycles; without a call-site try/catch, you lose the original error context and get a generic engine-level stack instead of a specific message with `{ cause }`
|
|
lint-js:
actions/setup/js/check_workflow_recompile_needed.cjs#L69
getExecOutput() is called with ignoreReturnCode: true but its exitCode is never read. Without the default throw-on-failure behavior, a non-zero exit code is silently ignored. Destructure exitCode and check it (e.g. `const { stdout, exitCode } = await exec.getExecOutput(...); if (exitCode !== 0) { ... }`)
|
|
lint-js:
actions/setup/js/check_stop_time.cjs#L38
This file imports error_codes.cjs but this thrown Error message does not reference a standardized error code (e.g. ERR_API, ERR_NOT_FOUND). Prefix the message with an imported ERR_* constant for consistency with other errors in this file
|
|
lint-js:
actions/setup/js/check_stop_time.cjs#L31
This file imports error_codes.cjs but this thrown Error message does not reference a standardized error code (e.g. ERR_API, ERR_NOT_FOUND). Prefix the message with an imported ERR_* constant for consistency with other errors in this file
|
|
lint-js:
actions/setup/js/check_stop_time.cjs#L26
This file imports error_codes.cjs but this thrown Error message does not reference a standardized error code (e.g. ERR_API, ERR_NOT_FOUND). Prefix the message with an imported ERR_* constant for consistency with other errors in this file
|
|
lint-js:
actions/setup/js/check_stop_time.cjs#L21
This file imports error_codes.cjs but this thrown Error message does not reference a standardized error code (e.g. ERR_API, ERR_NOT_FOUND). Prefix the message with an imported ERR_* constant for consistency with other errors in this file
|
|
lint-js:
actions/setup/js/build_checkout_manifest.cjs#L61
Prefer @actions/exec's exec()/getExecOutput() over child_process.execFileSync() to spawn processes in actions/github-script scripts. child_process.execFileSync() duplicates functionality already provided by the @actions/exec toolkit available in this context. @actions/exec's API is Promise-only, so migrating this call requires converting the enclosing (currently non-async) function — and every one of its callers up the chain — to async/await
|
|
lint-js:
actions/setup/js/build_checkout_manifest.cjs#L52
Prefer @actions/exec's exec()/getExecOutput() over child_process.execFileSync() to spawn processes in actions/github-script scripts. child_process.execFileSync() duplicates functionality already provided by the @actions/exec toolkit available in this context. @actions/exec's API is Promise-only, so migrating this call requires converting the enclosing (currently non-async) function — and every one of its callers up the chain — to async/await
|
|
lint-js:
actions/setup/js/artifact_client.cjs#L175
Wrap decodeURIComponent(raw.trim()) in try/catch — malformed percent-encoded input throws URIError; without a call-site try/catch, you lose the original error context and get a generic engine-level stack instead of a specific message with `{ cause }`
|