Skip to content

Commit 1f5c20e

Browse files
authored
Upgrade actions/github-script to v8 with Node.js 24 support (#8882)
1 parent d4f83cf commit 1f5c20e

11 files changed

Lines changed: 16 additions & 26 deletions

.github/aw/actions-lock.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,6 @@
3535
"version": "v6.0.0",
3636
"sha": "018cc2cf5baa6db3ef3c5f8a56943fffe632ef53"
3737
},
38-
"actions/github-script@v7.1.0": {
39-
"repo": "actions/github-script",
40-
"version": "v7.1.0",
41-
"sha": "f28e40c7f34bde8b3046d885e986cb6290c5673b"
42-
},
4338
"actions/github-script@v8.0.0": {
4439
"repo": "actions/github-script",
4540
"version": "v8.0.0",

.github/workflows/auto-close-parent-issues.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
runs-on: ubuntu-latest
1414
steps:
1515
- name: Auto-close parent issues when all sub-issues are closed
16-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
16+
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
1717
with:
1818
script: |
1919
const { owner, repo } = context.repo;

.github/workflows/install.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ jobs:
176176
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5
177177

178178
- name: Create issue on failure
179-
uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # v7
179+
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
180180
with:
181181
script: |
182182
const workflowUrl = `${context.serverUrl}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`;

.github/workflows/shared/ollama-threat-scan.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ safe-outputs:
2727
steps:
2828
- name: Ollama Llama Guard 3 Threat Scan
2929
id: ollama-scan
30-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
30+
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
3131
with:
3232
script: |
3333
const fs = require('fs');

docs/workflows/auto-close-parent-issues.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ The workflow uses **pagination** to handle parents with many sub-issues:
152152
## Technical Details
153153

154154
- **Runtime**: ubuntu-latest
155-
- **Action**: github-script@v7.0.1
155+
- **Action**: github-script@v8.0.0
156156
- **Language**: JavaScript
157157
- **API**: GitHub GraphQL API v4
158158

pkg/workflow/action_pins_logging_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ func TestActionPinResolutionWithMismatchedVersions(t *testing.T) {
3636
expectMismatch: true,
3737
},
3838
{
39-
name: "github-script v7.0.1 resolves to v8.0.0 pin (latest version)",
39+
name: "github-script v7 resolves to v8.0.0 pin (latest version)",
4040
repo: "actions/github-script",
41-
requestedVer: "v7.0.1",
41+
requestedVer: "v7",
4242
expectedPinVer: "v8.0.0", // Returns latest version for this repo
4343
expectMismatch: true,
4444
},

pkg/workflow/action_pins_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -347,9 +347,9 @@ func TestApplyActionPinToStep(t *testing.T) {
347347
func TestGetActionPinsSorting(t *testing.T) {
348348
pins := getActionPins()
349349

350-
// Verify we got all the pins (should be 29 as of this test after deduplication)
351-
if len(pins) != 29 {
352-
t.Errorf("getActionPins() returned %d pins, expected 29", len(pins))
350+
// Verify we got all the pins (should be 28 as of this test after deduplication)
351+
if len(pins) != 28 {
352+
t.Errorf("getActionPins() returned %d pins, expected 28", len(pins))
353353
}
354354

355355
// Verify they are sorted by version (descending) then by repository name (ascending)

pkg/workflow/action_sha_checker_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ jobs:
207207
steps:
208208
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5
209209
- uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6
210-
- uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
210+
- uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
211211
- name: Run tests
212212
run: npm test
213213
`
@@ -240,7 +240,7 @@ jobs:
240240
}{
241241
{"actions/checkout", "v5"},
242242
{"actions/setup-node", "v6"},
243-
{"actions/github-script", "v7.0.1"},
243+
{"actions/github-script", "v8.0.0"},
244244
}
245245

246246
for _, tt := range tests {

pkg/workflow/data/action_pins.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,6 @@
3535
"version": "v6.0.0",
3636
"sha": "018cc2cf5baa6db3ef3c5f8a56943fffe632ef53"
3737
},
38-
"actions/github-script@v7.1.0": {
39-
"repo": "actions/github-script",
40-
"version": "v7.1.0",
41-
"sha": "f28e40c7f34bde8b3046d885e986cb6290c5673b"
42-
},
4338
"actions/github-script@v8.0.0": {
4439
"repo": "actions/github-script",
4540
"version": "v8.0.0",

specs/actions.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -384,10 +384,10 @@ outputContent := filesRegex.ReplaceAllString(
384384
385385
### Decision 5: Node.js 20 Runtime
386386
387-
**Decision**: Use `node20` as the runtime for all actions.
387+
**Decision**: Use `node24` as the runtime for all actions.
388388
389389
**Rationale**:
390-
- Latest stable Node.js version supported by GitHub Actions
390+
- Latest stable Node.js version supported by GitHub Actions (v8.0.0+ of github-script)
391391
- Modern JavaScript features available
392392
- Consistent with workflow compilation environment
393393
@@ -427,7 +427,7 @@ jobs:
427427
required: true
428428
default: '/tmp/my-action'
429429
runs:
430-
using: 'node20'
430+
using: 'node24'
431431
main: 'index.js'
432432
```
433433
@@ -833,7 +833,7 @@ inputs:
833833
description: 'Path to agent output JSON file'
834834
required: true
835835
runs:
836-
using: 'node20'
836+
using: 'node24'
837837
main: 'index.js'
838838
EOF
839839

0 commit comments

Comments
 (0)