Add t.Parallel() to safe codemod tests in pkg/cli

Reviewed 25 codemod test files (pkg/cli/codemod_allowed_repos_current_test.go
through pkg/cli/codemod_github_app_client_id_test.go) for parallel-safety
and added t.Parallel() to top-level tests and table-driven subtests that
are demonstrably safe: pure functions operating on local content/frontmatter
values, no t.Setenv/os.Setenv/os.Chdir, no shared mutable globals, and
t.TempDir()-scoped file I/O only.

Validated with go test -race for all modified tests and go test ./pkg/cli/...
(pre-existing failures in compile_update_check_test.go and
engine_definition_test.go are unrelated sandbox network restrictions,
reproduced identically on main before these changes).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: github-actions[bot]

pkg/cli/codemod_allowed_repos_current_test.go

@@ -10,9 +10,11 @@ import (
 )
 
 func TestAllowedReposCurrentToGitHubRepositoryCodemod(t *testing.T) {
+	t.Parallel()
 	codemod := getAllowedReposCurrentToGitHubRepositoryCodemod()
 
 	t.Run("metadata is populated", func(t *testing.T) {
+		t.Parallel()
 		assert.Equal(t, "allowed-repos-current-to-github-repository", codemod.ID)
 		assert.NotEmpty(t, codemod.Name)
 		assert.NotEmpty(t, codemod.Description)
@@ -21,6 +23,7 @@ func TestAllowedReposCurrentToGitHubRepositoryCodemod(t *testing.T) {
 	})
 
 	t.Run("rewrites unquoted current value", func(t *testing.T) {
+		t.Parallel()
 		content := `---
 engine: copilot
 tools:
@@ -49,6 +52,7 @@ tools:
 	})
 
 	t.Run("rewrites quoted current value", func(t *testing.T) {
+		t.Parallel()
 		content := `---
 engine: copilot
 tools:
@@ -74,6 +78,7 @@ tools:
 	})
 
 	t.Run("rewrites single-quoted current value", func(t *testing.T) {
+		t.Parallel()
 		content := `---
 engine: copilot
 tools:
@@ -99,6 +104,7 @@ tools:
 	})
 
 	t.Run("no-op when allowed-repos is already an expression", func(t *testing.T) {
+		t.Parallel()
 		content := `---
 engine: copilot
 tools:
@@ -124,6 +130,7 @@ tools:
 	})
 
 	t.Run("no-op when allowed-repos is an array", func(t *testing.T) {
+		t.Parallel()
 		content := `---
 engine: copilot
 tools:
@@ -150,6 +157,7 @@ tools:
 	})
 
 	t.Run("no-op when allowed-repos is set to all", func(t *testing.T) {
+		t.Parallel()
 		content := `---
 engine: copilot
 tools:
@@ -175,6 +183,7 @@ tools:
 	})
 
 	t.Run("preserves trailing comments", func(t *testing.T) {
+		t.Parallel()
 		content := `---
 engine: copilot
 tools:
@@ -200,6 +209,7 @@ tools:
 	})
 
 	t.Run("only treats whitespace-preceded hash as a comment marker", func(t *testing.T) {
+		t.Parallel()
 		content := `---
 engine: copilot
 tools:
@@ -225,6 +235,7 @@ tools:
 	})
 
 	t.Run("does not rewrite nested non-top-level tools github allowed-repos", func(t *testing.T) {
+		t.Parallel()
 		content := `---
 engine: copilot
 wrapper:
@@ -262,6 +273,7 @@ tools:
 	})
 
 	t.Run("does not rewrite nested custom github allowed-repos", func(t *testing.T) {
+		t.Parallel()
 		content := `---
 engine: copilot
 tools:

pkg/cli/codemod_assign_to_agent_test.go

@@ -10,6 +10,7 @@ import (
 )
 
 func TestGetAssignToAgentDefaultAgentCodemod(t *testing.T) {
+	t.Parallel()
 	codemod := getAssignToAgentDefaultAgentCodemod()
 
 	assert.Equal(t, "assign-to-agent-default-agent-to-name", codemod.ID)
@@ -20,6 +21,7 @@ func TestGetAssignToAgentDefaultAgentCodemod(t *testing.T) {
 }
 
 func TestAssignToAgentCodemod_BasicMigration(t *testing.T) {
+	t.Parallel()
 	codemod := getAssignToAgentDefaultAgentCodemod()
 
 	content := `---
@@ -51,6 +53,7 @@ safe-outputs:
 }
 
 func TestAssignToAgentCodemod_PreservesIndentation(t *testing.T) {
+	t.Parallel()
 	codemod := getAssignToAgentDefaultAgentCodemod()
 
 	content := `---
@@ -82,6 +85,7 @@ safe-outputs:
 }
 
 func TestAssignToAgentCodemod_PreservesComment(t *testing.T) {
+	t.Parallel()
 	codemod := getAssignToAgentDefaultAgentCodemod()
 
 	content := `---
@@ -109,6 +113,7 @@ safe-outputs:
 }
 
 func TestAssignToAgentCodemod_NoSafeOutputs(t *testing.T) {
+	t.Parallel()
 	codemod := getAssignToAgentDefaultAgentCodemod()
 
 	content := `---
@@ -131,6 +136,7 @@ engine: copilot
 }
 
 func TestAssignToAgentCodemod_NoAssignToAgent(t *testing.T) {
+	t.Parallel()
 	codemod := getAssignToAgentDefaultAgentCodemod()
 
 	content := `---
@@ -158,6 +164,7 @@ safe-outputs:
 }
 
 func TestAssignToAgentCodemod_NoDefaultAgent(t *testing.T) {
+	t.Parallel()
 	codemod := getAssignToAgentDefaultAgentCodemod()
 
 	content := `---
@@ -185,6 +192,7 @@ safe-outputs:
 }
 
 func TestAssignToAgentCodemod_SkipsWhenNameAlreadyExists(t *testing.T) {
+	t.Parallel()
 	codemod := getAssignToAgentDefaultAgentCodemod()
 
 	content := `---
@@ -214,6 +222,7 @@ safe-outputs:
 }
 
 func TestAssignToAgentCodemod_PreservesOtherSafeOutputs(t *testing.T) {
+	t.Parallel()
 	codemod := getAssignToAgentDefaultAgentCodemod()
 
 	content := `---
@@ -248,6 +257,7 @@ safe-outputs:
 }
 
 func TestAssignToAgentCodemod_RegisteredInAllCodemods(t *testing.T) {
+	t.Parallel()
 	codemods := GetAllCodemods()
 	var found bool
 	for _, c := range codemods {

pkg/cli/codemod_bash_allowlist_unsupported_engine_test.go

@@ -12,6 +12,7 @@ import (
 )
 
 func TestBashAllowlistUnsupportedEngineCodemod_Metadata(t *testing.T) {
+	t.Parallel()
 	codemod := getBashAllowlistUnsupportedEngineCodemod()
 
 	assert.Equal(t, "bash-allowlist-unsupported-engine-guided-error", codemod.ID)
@@ -24,6 +25,7 @@ func TestBashAllowlistUnsupportedEngineCodemod_Metadata(t *testing.T) {
 }
 
 func TestBashAllowlistUnsupportedEngineCodemod_Apply(t *testing.T) {
+	t.Parallel()
 	codemod := getBashAllowlistUnsupportedEngineCodemod()
 
 	content := `---
@@ -150,6 +152,7 @@ tools:
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			newContent, applied, err := codemod.Apply(content, tt.frontmatter)
 			assert.False(t, applied, "guided codemod never modifies the workflow")
 			assert.Equal(t, content, newContent, "content must be preserved")
@@ -169,6 +172,7 @@ tools:
 // ApplyWithContext detects a bash restriction that originates solely from an imported file (not
 // the top-level workflow), which Apply cannot detect because it only sees raw frontmatter.
 func TestBashAllowlistUnsupportedEngineCodemod_ApplyWithContext_ImportedRestriction(t *testing.T) {
+	t.Parallel()
 	codemod := getBashAllowlistUnsupportedEngineCodemod()
 
 	dir := t.TempDir()
@@ -210,6 +214,7 @@ imports:
 // TestBashAllowlistUnsupportedEngineCodemod_ApplyWithContext_NoImportedRestriction verifies that
 // ApplyWithContext is a no-op when no bash restriction exists in the top-level or imported tools.
 func TestBashAllowlistUnsupportedEngineCodemod_ApplyWithContext_NoImportedRestriction(t *testing.T) {
+	t.Parallel()
 	codemod := getBashAllowlistUnsupportedEngineCodemod()
 
 	content := `---

pkg/cli/codemod_bash_anonymous_test.go

@@ -12,6 +12,7 @@ import (
 )
 
 func TestBashAnonymousRemovalCodemod(t *testing.T) {
+	t.Parallel()
 	codemod := getBashAnonymousRemovalCodemod()
 
 	tests := []struct {
@@ -86,6 +87,7 @@ name: Test Workflow
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			// Parse frontmatter to get the map
 			result, err := parser.ExtractFrontmatterFromContent(tt.input)
 			require.NoError(t, err, "Failed to parse test input frontmatter")
@@ -118,6 +120,7 @@ name: Test Workflow
 }
 
 func TestBashAnonymousCodemodWithComments(t *testing.T) {
+	t.Parallel()
 	codemod := getBashAnonymousRemovalCodemod()
 
 	input := `---
@@ -140,6 +143,7 @@ tools:
 }
 
 func TestBashAnonymousCodemodPreservesIndentation(t *testing.T) {
+	t.Parallel()
 	codemod := getBashAnonymousRemovalCodemod()
 
 	input := `---
@@ -172,6 +176,7 @@ tools:
 }
 
 func TestReplaceBashAnonymousWithTrue(t *testing.T) {
+	t.Parallel()
 	tests := []struct {
 		name        string
 		lines       []string
@@ -230,6 +235,7 @@ func TestReplaceBashAnonymousWithTrue(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			result, modified := replaceBashAnonymousWithTrue(tt.lines)
 			assert.Equal(t, tt.modified, modified, "Modified status mismatch")
 			assert.Equal(t, tt.expectLines, result, "Output lines mismatch")

pkg/cli/codemod_bash_single_quoted_args_test.go

@@ -11,6 +11,7 @@ import (
 )
 
 func TestGetBashSingleQuotedArgsCodemod(t *testing.T) {
+	t.Parallel()
 	codemod := getBashSingleQuotedArgsCodemod()
 
 	assert.Equal(t, "bash-single-quoted-args-rewrite", codemod.ID)
@@ -21,6 +22,7 @@ func TestGetBashSingleQuotedArgsCodemod(t *testing.T) {
 }
 
 func TestBashSingleQuotedArgsCodemod_RewritesSimpleSingleQuotedArg(t *testing.T) {
+	t.Parallel()
 	codemod := getBashSingleQuotedArgsCodemod()
 	content := `---
 name: test
@@ -50,6 +52,7 @@ Test workflow body`
 }
 
 func TestBashSingleQuotedArgsCodemod_RewritesGlobPatterns(t *testing.T) {
+	t.Parallel()
 	codemod := getBashSingleQuotedArgsCodemod()
 	content := `---
 name: test
@@ -78,6 +81,7 @@ body`
 }
 
 func TestBashSingleQuotedArgsCodemod_NoOpForAlreadySafeEntry(t *testing.T) {
+	t.Parallel()
 	codemod := getBashSingleQuotedArgsCodemod()
 	content := `---
 name: test
@@ -101,6 +105,7 @@ body`
 }
 
 func TestBashSingleQuotedArgsCodemod_UnmatchedQuoteLeftUnchanged(t *testing.T) {
+	t.Parallel()
 	codemod := getBashSingleQuotedArgsCodemod()
 	content := `---
 name: test
@@ -124,6 +129,7 @@ body`
 }
 
 func TestRewriteSingleQuotedBashArgs(t *testing.T) {
+	t.Parallel()
 	tests := []struct {
 		name      string
 		input     string
@@ -184,6 +190,7 @@ func TestRewriteSingleQuotedBashArgs(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			got, safe, changed := rewriteSingleQuotedBashArgs(tt.input)
 			assert.Equal(t, tt.want, got)
 			assert.Equal(t, tt.wantSafe, safe)

pkg/cli/codemod_bots_test.go

@@ -12,6 +12,7 @@ import (
 )
 
 func TestGetBotsToOnBotsCodemod(t *testing.T) {
+	t.Parallel()
 	codemod := getBotsToOnBotsCodemod()
 
 	assert.Equal(t, "bots-to-on-bots", codemod.ID)
@@ -22,6 +23,7 @@ func TestGetBotsToOnBotsCodemod(t *testing.T) {
 }
 
 func TestBotsToOnBotsCodemod_SingleLineArray(t *testing.T) {
+	t.Parallel()
 	codemod := getBotsToOnBotsCodemod()
 
 	content := `---
@@ -68,6 +70,7 @@ bots: [dependabot, renovate]
 }
 
 func TestBotsToOnBotsCodemod_MultiLineArray(t *testing.T) {
+	t.Parallel()
 	codemod := getBotsToOnBotsCodemod()
 
 	content := `---
@@ -103,6 +106,7 @@ bots:
 }
 
 func TestBotsToOnBotsCodemod_NoOnBlock(t *testing.T) {
+	t.Parallel()
 	codemod := getBotsToOnBotsCodemod()
 
 	content := `---
@@ -130,6 +134,7 @@ engine: copilot
 }
 
 func TestBotsToOnBotsCodemod_NoChange_NoBots(t *testing.T) {
+	t.Parallel()
 	codemod := getBotsToOnBotsCodemod()
 
 	content := `---
@@ -158,6 +163,7 @@ engine: copilot
 }
 
 func TestBotsToOnBotsCodemod_NoChange_OnBotsExists(t *testing.T) {
+	t.Parallel()
 	codemod := getBotsToOnBotsCodemod()
 
 	content := `---

pkg/cli/codemod_byok_copilot_test.go

@@ -11,6 +11,7 @@ import (
 )
 
 func TestByokCopilotFeatureRemovalCodemod(t *testing.T) {
+	t.Parallel()
 	codemod := getByokCopilotFeatureRemovalCodemod()
 
 	tests := []struct {
@@ -56,6 +57,7 @@ features:
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			result, err := parser.ExtractFrontmatterFromContent(tt.input)
 			require.NoError(t, err, "Failed to parse test input frontmatter")