[Schema Consistency] Error Documentation Consistency Check - 2026-01-27 #12133
Closed
Replies: 1 comment
-
|
This discussion was automatically closed because it expired on 2026-02-03T23:54:30.872Z. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
This automated analysis examined error message consistency across schema definitions, parser/compiler code, and documentation to identify gaps where users might encounter undocumented errors.
Analysis Overview
Strategy: Error Path & Exception Handling Consistency Analysis (NEW)
Approach: Radically different from previous 18 strategies
Date: 2026-01-27
Workflow Run: §21418811357
Key Metrics
Critical Issues
1. dispatch-workflow Errors Completely Missing
Severity: Critical - Security-related feature
The
dispatch-workflowsafe-output has comprehensive validation with 3 security-critical error messages, but NONE are documented:Status: Validation implemented in
pkg/parser/import_processor.gobut not documentedImpact: Users attempting to use imports within Handlebars template blocks will encounter this error with no documentation.
Use case: This prevents incorrect patterns like:
Recommendation: Add to "Compilation Errors" section in errors.md with explanation of the limitation and workarounds.
3. Cron Expression Validation Errors Not Documented
Error messages:
fuzzy cron expression '%s' must be scattered to proper cron format before compilationinvalid cron expression '%s': must have exactly 5 fields (minute hour day-of-month month day-of-week)Status: Validation exists in
pkg/workflow/schedule.gobut not documentedImpact: Users with invalid schedule cron expressions won't find troubleshooting guidance.
Recommendation: Add "Schedule Configuration Errors" section with cron expression format requirements and fuzzy expression documentation.
Moderate Issues
4. slash_command Error Documentation Incomplete
Current documentation: Only covers
commandfield conflict errorMissing:
slash_commandfield conflict errorError messages:
cannot use 'command' with '%s' in the same workflow✓ Documentedcannot use 'slash_command' with '%s' in the same workflow✗ NOT DocumentedImpact: Users using the newer
slash_commandfield (recommended) won't find their error variant in documentation.Recommendation: Update existing error entry to include both field names or add note that error applies to both
commandandslash_command.5. GitHub Actions Mutual Exclusivity Errors Missing
Error messages:
%s event cannot specify both 'branches' and 'branches-ignore'...%s event cannot specify both 'paths' and 'paths-ignore'...Status: Runtime validation in
pkg/workflow/compiler_events.gobut not documentedImpact: Users violating GitHub Actions mutual exclusivity constraints won't find guidance in error reference.
Recommendation: Add "Trigger Filter Errors" section documenting mutual exclusivity requirements.
6. Action SHA Format Validation Error
Error message:
invalid SHA format for %s@%s: %sStatus: Validation in action pinning code but not documented
Recommendation: Add to action pinning troubleshooting section with SHA format requirements.
7. Engine Validation Error
Error message:
invalid engine: %s. Valid engines are: copilot, claude, codex, custom. Example: engine: copilotStatus: Self-explanatory error but not in documentation
Recommendation: Add to engine configuration errors section for completeness.
8. Generic Range Validation Error Format
Error pattern:
%s must be between %d and %d, got %dApplied to: Multiple fields (port, retention-days, etc.)
Status: Generic error used across many fields but specific constraints not documented
Recommendation: Document common range-validated fields with their specific constraints.
Positive Findings
View Excellent Implementation Examples
✓ tracker-id Validation (EXCELLENT)
All three schema constraints enforced with clear error messages:
"tracker-id must be at least 8 characters long (got %d)"^[a-zA-Z0-9_-]+$→"tracker-id contains invalid character at position %d: '%c' (only alphanumeric, hyphens, and underscores allowed)"Location:
pkg/workflow/frontmatter_extraction_metadata.go:63-91✓ branch-prefix Validation (EXCELLENT)
Complete constraint enforcement:
"branch-prefix must be at least 4 characters long, got %d""branch-prefix must be at most 32 characters long, got %d""branch-prefix cannot be 'copilot' (reserved)"✓ Strict Mode Error Documentation (EXCELLENT)
All 10 strict mode errors comprehensively documented in errors.md with:
✓ Error Message Quality (EXCELLENT)
Error messages consistently follow best practices:
Architectural Insights
Error Handling Architecture
The codebase follows a clear separation:
Documentation Gap Patterns
Most undocumented errors fall into these categories:
Schema Constraint Coverage
Schema defines 247 constraints:
Runtime validation approach:
This selective approach is intentional - schema validation catches most issues, runtime validates critical security and business logic constraints.
Recommendations
High Priority (Documentation Gaps)
Medium Priority (Completeness)
Low Priority (Enhancement)
Architectural (Future Improvement)
Strategy Performance
Effectiveness
Rating: Very High - Found 8 inconsistencies in first run
Unique value:
Methodology
This analysis:
fmt.Errorf,errors.New)docs/src/content/docs/troubleshooting/errors.mdComplementary Strategies
Works well with:
Recommendation
Use every 5-6 analyses to validate error documentation stays current as new features and validations are added.
Trigger after:
Next Steps
References:
Beta Was this translation helpful? Give feedback.
All reactions