Fix false-positive heredoc detection on bare `(( ))` arithmetic in generatedyamlheredoc linter by Copilot · Pull Request #53991 · github/gh-aw

Copilot · 2026-08-19T12:19:09Z

lineContainsShellHeredoc only recognized $(( as an arithmetic-expansion context guard for <<, so bare (( expr << n )) arithmetic commands/conditionals were misreported as shell heredocs.

Changes

pkg/linters/generatedyamlheredoc/generatedyamlheredoc.go: Broadened the arithmetic guard to search for (( instead of $((. Since $(( always contains (( as a suffix, a single (( search covers both spellings without redundant logic.
pkg/linters/generatedyamlheredoc/testdata/src/generatedyamlheredoc/generatedyamlheredoc.go: Added test cases for (( count << 1 )) and if (( a << 2 )); then to lock in the fix, alongside the existing $((1 << 2)) case.

// Previously flagged as a heredoc (false positive), now correctly ignored:
"(( count << 1 ))\n"
"if (( a << 2 )); then\n"

Fixes generatedyamlheredoc: bare (( ... )) arithmetic with << is misreported as a heredoc #53901

run: https://github.com/github/gh-aw/actions/runs/32276767055> Generated by 👨‍🍳 PR Sous Chef · gpt54 · 26.4 AIC · ⌖ 9.42 AIC · ⊞ 9.3K · ◷

_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-08-19T12:26:35Z

PR Triage

Category: bug
Risk: low
Priority score: 10/100 (impact 5 + urgency 3 + quality 2)
Recommended action: defer

WIP placeholder PR (0 diff) for bare arithmetic heredoc misreporting fix; no substantive changes yet.

Generated by 🔧 PR Triage Agent · auto · 44.3 AIC · ⌖ 2.78 AIC · ⊞ 8.3K · ◷

github-actions · 2026-08-19T12:28:09Z

✅ Ponytail Reviewer completed successfully!

Lean already. Ship.

Generated by Ponytail Reviewer for #53991

github-actions · 2026-08-19T12:28:09Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions · 2026-08-19T12:28:10Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #53991 does not have the 'implementation' label and has only 4 new lines of code in business logic directories (threshold: 100).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

github-actions · 2026-08-19T12:28:10Z

✅ Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel skipped. This PR modified production code in the generatedyamlheredoc linter and added test data inputs (testdata/), but no behavioral test functions (*_test.go) were added or changed.

🧪 Test quality analysis by Test Quality Sentinel

github-actions · 2026-08-19T12:28:30Z

✅ PR Code Quality Reviewer completed the code quality review.

Completed PR review with no GitHub write because no actionable review comments were warranted; the changed linter logic and tests look correct, and the only candidate concern was speculative.

🔎 Code quality review by PR Code Quality Reviewer

github-actions

Skills-Based Review 🧠

Applied /diagnosing-bugs and /tdd — approving; one minor comment on the guard's precision.

📋 Key Themes & Highlights

Key Themes

Root cause properly addressed: the guard is broadened from $(( to ((, which is the correct minimal change.
Regression tests added: both new arithmetic patterns ((( count << 1 )) and if (( a << 2 )); then) are covered by testdata.

Positive Highlights

✅ Minimal, surgical diff — only the lines that needed to change were touched.
✅ Test cases correctly validate the absence of false positives.
✅ PR description is clear and self-contained.

Minor observation

The inline comment says "$((" is also matched here, since it contains "((" as a suffix — technically (( is a substring (at offset 1), not a suffix. Consider: // "$((" is also covered since it contains "((" as a substring.

Also worth noting: broadening to (( will now skip any shell string that contains a bare (( before a <<. This is the correct trade-off for a false-positive fix in this domain, but a short code comment documenting the known limitation would help future maintainers.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 19.2 AIC · ⌖ 9.87 AIC · ⊞ 7.8K
_{Comment /matt to run again}

github-actions · 2026-08-19T12:32:48Z

Comment Memory

reviewed_at: 2026-08-19T00:00:00Z
review_event: COMMENT
top_themes:
  - no actionable issues in changed lines
  - arithmetic false-positive guard covered by added tests
files_reviewed:
  - pkg/linters/generatedyamlheredoc/generatedyamlheredoc.go
  - pkg/linters/generatedyamlheredoc/testdata/src/generatedyamlheredoc/generatedyamlheredoc.go
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 2.62 AIC · ⌖ 6.73 AIC · ⊞ 7K · ◷
_{Comment /review to run again}

github-actions

The fix is correct and minimal. Changing "$((" to "((" properly handles bare (( )) arithmetic expressions where << is a left-shift operator, not a heredoc. The inline comment clarifies that "$((" is a special case of "((", and the two new test cases cover the regression.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 21 AIC · ⌖ 8.79 AIC · ⊞ 5.7K

Copilot

Pull request overview

Broadens heredoc detection to recognize bare Bash arithmetic commands using (( )).

Changes:

Matches (( as an arithmetic context.
Adds bare arithmetic shift fixtures.

Show a summary per file

File	Description
`pkg/linters/generatedyamlheredoc/generatedyamlheredoc.go`	Expands arithmetic detection.
`pkg/linters/generatedyamlheredoc/testdata/src/generatedyamlheredoc/generatedyamlheredoc.go`	Adds regression fixtures.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Files reviewed: 2/2 changed files
Comments generated: 1
Review effort level: Balanced

 		}
-		if strings.LastIndex(line[:operatorIndex], "$((") > strings.LastIndex(line[:operatorIndex], "))") {
+		// "$((" is also matched here, since it contains "((" as a suffix.
+		if strings.LastIndex(line[:operatorIndex], "((") > strings.LastIndex(line[:operatorIndex], "))") {


github-actions · 2026-08-19T13:13:28Z

Thanks for this fix! 🎯 The PR correctly addresses the bug where bare (( )) arithmetic syntax was being flagged as shell heredocs. The change to search for (( instead of $(( is elegant — since $(( always contains (( as a suffix, this single check covers both cases without redundancy.

✅ This PR looks ready for review:

Focused change: one logical fix to the arithmetic-expansion guard
Tests included: new test cases for (( count << 1 )) and if (( a << 2 )); then lock in the fix
Clear description: well-documented rationale and changes
Low risk: minimal diff affecting only linter logic and tests for the same component

Great work shipping this through the agentic workflow!

Generated by ✅ Contribution Check · auto · 50.1 AIC · ⌖ 10.5 AIC · ⊞ 9.2K · ◷

Copilot · 2026-08-19T13:22:41Z

@copilot This PR looks close, but it still needs a maintainer-facing finish pass.

Please refresh the branch if needed....

Finish pass complete. The branch already matches the PR base, so no refresh was needed. Validation: make fmt, make test-unit, make test, and make recompile passed; make lint is blocked only by three pre-existing testifylint findings in pkg/intent/governance_formal_test.go. No failed CI job is present (one cache job was cancelled; Copilot remains in progress). Remaining risks: the unresolved inline review thread still needs maintainer disposition, and the current CI check must complete before merge.

gh-aw-bot · 2026-08-19T16:42:57Z

@copilot This PR looks close, but it still needs a maintainer-facing finish pass.

Please refresh the branch if GitHub offers one.
There is still an unresolved inline review thread to resolve or answer.
Then run the pr-finisher skill and leave a concise maintainer-facing handoff comment with validation and any remaining risks.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 26.4 AIC · ⌖ 9.42 AIC · ⊞ 9.3K · ◷
_{Comment /souschef to run again}

…reporting

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-08-19T17:11:29Z

@copilot This PR looks close, but it still needs a maintainer-facing finish pass.

Please refresh the branch if GitHub offers one....

Addressed in 80a38f4: quoted (( no longer suppresses a following heredoc, with the requested printf … '((' && cat <<EOF regression fixture. The branch was already refreshed with main. Validation passed: make agent-report-progress, make test, and make recompile; CodeQL found no alerts. The inline review is addressed by this commit, but this environment does not expose a thread-resolution operation. Remaining risk: CI on the new head has not been rerun by this agent.

github-actions · 2026-08-19T18:30:14Z

PR Triage

Category: bug · Risk: low · Score: 40/100 (impact 15 + urgency 10 + quality 15)
Recommended action: fast_track
Batch: B2-linter-fixes

Linter false-positive fix, 2x APPROVED reviews; ready pending CI green.

Automated triage — see run report for full details.

Generated by 🔧 PR Triage Agent · auto · 90.2 AIC · ⌖ 2.82 AIC · ⊞ 8.3K · ◷

gh-aw-bot · 2026-08-19T19:54:15Z

@copilot PR is close, but there is still maintainer-visible follow-up needed.

Please complete one final pass:

Resolve or answer the remaining unresolved inline review thread directly.
Refresh the branch if GitHub offers one.
Then run the pr-finisher skill and leave a concise maintainer-facing handoff comment with validation and remaining risks.

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 31.4 AIC · ⌖ 8.18 AIC · ⊞ 9.3K · ◷
_{Comment /souschef to run again}

Copilot · 2026-08-19T20:09:21Z

@copilot PR is close, but there is still maintainer-visible follow-up needed.

Please complete one final pass:...

Final pass complete. main is already an ancestor of 80a38f4; no refresh is offered. The outstanding inline thread is outdated and its quoted-literal concern is addressed by 80a38f4, but this environment exposes no thread-resolution operation. Local validation: make fmt, make test-unit, make test, and make recompile passed; make lint remains blocked only by the same three pre-existing testifylint findings in pkg/intent/governance_formal_test.go on main. The two prior CI runs have no jobs or failed-job logs; CI for the agent head remains unverified and must be re-triggered by a maintainer before merge.

gh-aw-bot · 2026-08-19T20:59:45Z

@copilot PR is close, but there is still maintainer-visible follow-up needed.

Please complete one final pass:

Resolve or answer the remaining unresolved inline review thread directly.
Refresh the branch if GitHub offers one.
Then run the pr-finisher skill and leave a concise maintainer-facing handoff comment with validation and remaining risks.

Open review threads (newest first):

Copilot: quoted (( literal can suppress a real later heredoc; confirm the current-head fix on-thread and resolve if addressed — Fix false-positive heredoc detection on bare (( )) arithmetic in generatedyamlheredoc linter #53991 (comment)

Checks are no longer running on the current head, so this is ready for that final maintainer-facing sweep.

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 19.9 AIC · ⌖ 8.28 AIC · ⊞ 9.3K · ◷
_{Comment /souschef to run again}

…heredoc-fix-arithmetic-reporting Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-08-19T21:20:53Z

@copilot PR is close, but there is still maintainer-visible follow-up needed.

Please complete one final pass:...

Refreshed in a117313996 by merging current main with no conflicts. Confirmed the current-head 80a38f4 fix: quoted (( is ignored by the arithmetic detector, and the requested printf '%s\n' '((' && cat <<EOF regression fixture detects the real heredoc. Local validation after refresh passed via make agent-report-progress (format, changed-file lint, impacted tests, and workflow lock sync); make test and make recompile also passed. The review thread is outdated; this environment exposes no direct thread-reply or resolve operation. CI was inspected: the current dynamic run has no failed-job logs, but CI on the refreshed agent head must be re-triggered by a maintainer before merge. Remaining risk: the known three pre-existing testifylint findings in pkg/intent/governance_formal_test.go still block full make lint.

github-actions · 2026-08-20T00:31:51Z

PR Triage

Category: bug
Risk: low
Priority score: 61 / 100 (impact 25 + urgency 20 + quality 16)
Recommended action: fast_track

Batch: B2-linter-fixes

Small, well-scoped linter fix (add:53/del:1) for a false-positive heredoc detection bug. CI mostly green.

Automated triage by PR Triage Agent.

Generated by 🔧 PR Triage Agent · auto · 57.1 AIC · ⌖ 2.88 AIC · ⊞ 8.3K · ◷

…reporting

Initial plan

9f00d91

Copilot AI assigned Copilot and pelikhan Aug 19, 2026

Copilot started work on behalf of pelikhan August 19, 2026 12:19 View session

Copilot AI linked an issue Aug 19, 2026 that may be closed by this pull request

generatedyamlheredoc: bare (( ... )) arithmetic with << is misreported as a heredoc #53901

Open

Copilot AI and others added 2 commits August 19, 2026 12:24

Fix generatedyamlheredoc: recognize bare (( )) arithmetic

1a17efa

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Simplify arithmetic guard per review feedback

c58acc3

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions Bot added pr-action:defer pr-agent:copilot pr-priority:low pr-risk:low pr-type:bug labels Aug 19, 2026

Copilot AI changed the title ~~[WIP] Fix misreporting of bare arithmetic with heredocs~~ Fix false-positive heredoc detection on bare (( )) arithmetic in generatedyamlheredoc linter Aug 19, 2026

Copilot finished work on behalf of pelikhan August 19, 2026 12:26

Copilot AI requested a review from pelikhan August 19, 2026 12:26

github-actions Bot mentioned this pull request Aug 19, 2026

[PR Triage Report] PR Triage Report — 2026-08-19 (Run 32251836165) #53992

Closed

pelikhan marked this pull request as ready for review August 19, 2026 12:26

Copilot AI balanced review requested due to automatic review settings August 19, 2026 12:27

Copilot started reviewing on behalf of pelikhan August 19, 2026 12:27 View session

github-actions Bot approved these changes Aug 19, 2026

View reviewed changes

Copilot AI reviewed Aug 19, 2026

View reviewed changes

github-actions Bot mentioned this pull request Aug 19, 2026

[aw] No-Op Runs #48838

Open

github-actions Bot mentioned this pull request Aug 19, 2026

[Contribution Check Report] Contribution Check — 2026-08-19 #53884

Closed

Copilot finished work on behalf of gh-aw-bot August 19, 2026 13:23

Copilot AI requested a review from gh-aw-bot August 19, 2026 13:23

Merge branch 'main' into copilot/generatedyamlheredoc-fix-arithmetic-…

a9ff623

…reporting

Copilot started work on behalf of gh-aw-bot August 19, 2026 16:43 View session

Fix quoted arithmetic heredoc detection

80a38f4

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot August 19, 2026 17:11

github-actions Bot added pr-action:fast_track pr-priority:medium pr-batch:B2-linter-fixes labels Aug 19, 2026

github-actions Bot mentioned this pull request Aug 19, 2026

[PR Triage Report] PR Triage Report — 2026-08-19 (Run 32286379053) #54060

Closed

Copilot started work on behalf of gh-aw-bot August 19, 2026 19:54 View session

Copilot finished work on behalf of gh-aw-bot August 19, 2026 20:09

Copilot started work on behalf of gh-aw-bot August 19, 2026 21:00 View session

Merge remote-tracking branch 'origin/main' into copilot/generatedyaml…

a117313

…heredoc-fix-arithmetic-reporting Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot August 19, 2026 21:21

github-actions Bot mentioned this pull request Aug 20, 2026

[pr-sous-chef] PR Sous Chef run report #54095

Open

github-actions Bot added the pr-priority:high label Aug 20, 2026

github-actions Bot mentioned this pull request Aug 20, 2026

[PR Triage Report] PR Triage Report — 2026-08-20 (Run 32317108570) #54102

Open

Merge branch 'main' into copilot/generatedyamlheredoc-fix-arithmetic-…

f296e89

…reporting

Uh oh!

Conversation

Copilot AI commented Aug 19, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

github-actions Bot commented Aug 19, 2026

PR Triage

Uh oh!

github-actions Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Key Themes

Positive Highlights

Minor observation

Uh oh!

github-actions Bot commented Aug 19, 2026

Comment Memory

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

Copilot AI commented Aug 19, 2026

Uh oh!

gh-aw-bot commented Aug 19, 2026

Uh oh!

Copilot AI commented Aug 19, 2026

Uh oh!

github-actions Bot commented Aug 19, 2026

PR Triage

Uh oh!

gh-aw-bot commented Aug 19, 2026

Uh oh!

Copilot AI commented Aug 19, 2026

Uh oh!

gh-aw-bot commented Aug 19, 2026

Uh oh!

Copilot AI commented Aug 19, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

PR Triage

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Aug 19, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Aug 19, 2026 •

edited

Loading

github-actions Bot commented Aug 19, 2026 •

edited

Loading

github-actions Bot commented Aug 19, 2026 •

edited

Loading

github-actions Bot commented Aug 19, 2026 •

edited

Loading

github-actions Bot commented Aug 19, 2026 •

edited

Loading