From cf5ebe90d3f0a8d32dd2bb3ca9cc644ee2e3e565 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue, 18 Aug 2026 07:00:14 +0000 Subject: [PATCH] test: add t.Parallel() to safe codemod tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adds t.Parallel() to TestGetPermissionsReadCodemod and related permissions codemod tests, plus TestMCPModeToTypeCodemod and its subtests. Each test constructs its own local Codemod instance (a plain struct with pure function fields) and only touches local content/frontmatter variables — no shared mutable state, env vars, working directory changes, fixed ports/paths, or external services. Validated with go test -race on the affected tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- pkg/cli/codemod_mcp_mode_to_type_test.go | 7 +++++++ pkg/cli/codemod_permissions_test.go | 22 ++++++++++++++++++++++ 2 files changed, 29 insertions(+) diff --git a/pkg/cli/codemod_mcp_mode_to_type_test.go b/pkg/cli/codemod_mcp_mode_to_type_test.go index 9d2f1301935..e413f79b986 100644 --- a/pkg/cli/codemod_mcp_mode_to_type_test.go +++ b/pkg/cli/codemod_mcp_mode_to_type_test.go @@ -10,9 +10,11 @@ import ( ) func TestMCPModeToTypeCodemod(t *testing.T) { + t.Parallel() codemod := getMCPModeToTypeCodemod() t.Run("renames mode to type in custom MCP servers", func(t *testing.T) { + t.Parallel() content := `--- engine: copilot tools: @@ -49,6 +51,7 @@ mcp-servers: }) t.Run("does not modify workflows without mcp-servers", func(t *testing.T) { + t.Parallel() content := `--- engine: copilot tools: @@ -75,6 +78,7 @@ tools: }) t.Run("does not modify GitHub tool mode field", func(t *testing.T) { + t.Parallel() content := `--- engine: copilot tools: @@ -113,6 +117,7 @@ mcp-servers: }) t.Run("handles multiple MCP servers with mode", func(t *testing.T) { + t.Parallel() content := `--- engine: copilot mcp-servers: @@ -151,6 +156,7 @@ mcp-servers: }) t.Run("does not modify when no mode field exists", func(t *testing.T) { + t.Parallel() content := `--- engine: copilot mcp-servers: @@ -179,6 +185,7 @@ mcp-servers: }) t.Run("preserves comments and formatting", func(t *testing.T) { + t.Parallel() content := `--- engine: copilot mcp-servers: diff --git a/pkg/cli/codemod_permissions_test.go b/pkg/cli/codemod_permissions_test.go index 7d177070bcf..a31f6f74716 100644 --- a/pkg/cli/codemod_permissions_test.go +++ b/pkg/cli/codemod_permissions_test.go @@ -10,6 +10,7 @@ import ( ) func TestGetPermissionsReadCodemod(t *testing.T) { + t.Parallel() codemod := getExpandPermissionsShorthandCodemod() assert.Equal(t, "permissions-read-to-read-all", codemod.ID) @@ -20,6 +21,7 @@ func TestGetPermissionsReadCodemod(t *testing.T) { } func TestPermissionsReadCodemod_Read(t *testing.T) { + t.Parallel() codemod := getExpandPermissionsShorthandCodemod() content := `--- @@ -43,6 +45,7 @@ permissions: read } func TestPermissionsReadCodemod_Write(t *testing.T) { + t.Parallel() codemod := getExpandPermissionsShorthandCodemod() content := `--- @@ -66,6 +69,7 @@ permissions: write } func TestPermissionsReadCodemod_NoChange_ReadAll(t *testing.T) { + t.Parallel() codemod := getExpandPermissionsShorthandCodemod() content := `--- @@ -88,6 +92,7 @@ permissions: read-all } func TestPermissionsReadCodemod_NoChange_WriteAll(t *testing.T) { + t.Parallel() codemod := getExpandPermissionsShorthandCodemod() content := `--- @@ -110,6 +115,7 @@ permissions: write-all } func TestPermissionsReadCodemod_NoChange_MapFormat(t *testing.T) { + t.Parallel() codemod := getExpandPermissionsShorthandCodemod() content := `--- @@ -137,6 +143,7 @@ permissions: } func TestPermissionsReadCodemod_NoPermissions(t *testing.T) { + t.Parallel() codemod := getExpandPermissionsShorthandCodemod() content := `--- @@ -159,6 +166,7 @@ timeout-minutes: 30 } func TestPermissionsReadCodemod_PreservesMarkdown(t *testing.T) { + t.Parallel() codemod := getExpandPermissionsShorthandCodemod() content := `--- @@ -184,6 +192,7 @@ This workflow needs permissions.` } func TestGetWritePermissionsCodemod(t *testing.T) { + t.Parallel() codemod := getMigrateWritePermissionsToReadCodemod() assert.Equal(t, "write-permissions-to-read-migration", codemod.ID) @@ -194,6 +203,7 @@ func TestGetWritePermissionsCodemod(t *testing.T) { } func TestWritePermissionsCodemod_ShorthandWriteAll(t *testing.T) { + t.Parallel() codemod := getMigrateWritePermissionsToReadCodemod() content := `--- @@ -217,6 +227,7 @@ permissions: write-all } func TestWritePermissionsCodemod_ShorthandWrite(t *testing.T) { + t.Parallel() codemod := getMigrateWritePermissionsToReadCodemod() content := `--- @@ -240,6 +251,7 @@ permissions: write } func TestWritePermissionsCodemod_MapFormat(t *testing.T) { + t.Parallel() codemod := getMigrateWritePermissionsToReadCodemod() content := `--- @@ -269,6 +281,7 @@ permissions: } func TestWritePermissionsCodemod_MultipleWritePermissions(t *testing.T) { + t.Parallel() codemod := getMigrateWritePermissionsToReadCodemod() content := `--- @@ -300,6 +313,7 @@ permissions: } func TestWritePermissionsCodemod_NoPermissionsField(t *testing.T) { + t.Parallel() codemod := getMigrateWritePermissionsToReadCodemod() content := `--- @@ -322,6 +336,7 @@ timeout-minutes: 30 } func TestWritePermissionsCodemod_OnlyReadPermissions(t *testing.T) { + t.Parallel() codemod := getMigrateWritePermissionsToReadCodemod() content := `--- @@ -349,6 +364,7 @@ permissions: } func TestWritePermissionsCodemod_PreservesIndentation(t *testing.T) { + t.Parallel() codemod := getMigrateWritePermissionsToReadCodemod() content := `--- @@ -377,6 +393,7 @@ permissions: } func TestWritePermissionsCodemod_PreservesComments(t *testing.T) { + t.Parallel() codemod := getMigrateWritePermissionsToReadCodemod() content := `--- @@ -405,6 +422,7 @@ permissions: } func TestWritePermissionsCodemod_PreservesMarkdown(t *testing.T) { + t.Parallel() codemod := getMigrateWritePermissionsToReadCodemod() content := `--- @@ -430,6 +448,7 @@ This workflow needs permissions.` } func TestWritePermissionsCodemod_SkipsIdToken(t *testing.T) { + t.Parallel() codemod := getMigrateWritePermissionsToReadCodemod() content := `--- @@ -459,6 +478,7 @@ permissions: } func TestWritePermissionsCodemod_SkipsCopilotRequests(t *testing.T) { + t.Parallel() codemod := getMigrateWritePermissionsToReadCodemod() content := `--- @@ -488,6 +508,7 @@ permissions: } func TestWritePermissionsCodemod_MixedWithIdToken(t *testing.T) { + t.Parallel() codemod := getMigrateWritePermissionsToReadCodemod() content := `--- @@ -521,6 +542,7 @@ permissions: } func TestWritePermissionsCodemod_MixedWithCopilotRequests(t *testing.T) { + t.Parallel() codemod := getMigrateWritePermissionsToReadCodemod() content := `---