You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3c43b5e
Browse filesBrowse the repository at this point in the historyBrowse files
## Why
Replica's package manifests exclude Node 26 even though its JavaScript
tooling can run on it. The locked Hub and test dependencies make Node
24.15.0 the lowest common supported version.
## What changes
Allow `^24.15.0 || ^26.0.0` in Hub, Starter, the build action, and
Learning, with matching lockfile metadata. Extend existing
Node-dependent CI jobs with a Node 24 and 26 matrix instead of adding a
separate compatibility workflow. Individual checks and frontend test
sharding stay separate.
Preserve existing Node 24 check names and add a `(Node 26)` suffix to
the new matrix results. Existing result gates require both versions to
pass. Container images and the composite action retain their Node 24
defaults; its smoke test runs only once because it pins that runtime and
uploads a single named artifact. Update the existing workflow guards and
contributor guidance to match.
The matrix tracks each supported major rather than its exact minimum
patch release. Exact Node 24.15.0 and 26.0.0 runtime behavior remains
unverified.
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+3-1Lines changed: 3 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -25,6 +25,8 @@ For improvements, explain the problem you want to solve and who would benefit. D
25
25
26
26
## Set up the development environment
27
27
28
+
Each Node.js project's `engines.node` declares its supported versions. The existing Hub, Starter, build-action, and Learning CI checks run on both supported Node majors. The devcontainer, production image, and composite build action retain their pinned runtime defaults; choosing another supported major locally does not change them.
29
+
28
30
### Replica Hub
29
31
30
32
Replica Hub uses a devcontainer so contributors run the same Ruby, Node, SQLite, GitHub CLI, and Chromium versions.
@@ -85,7 +87,7 @@ npm test
85
87
86
88
### Replica learning
87
89
88
-
The learning package requires Node.js 24, npm, and Git:
90
+
The learning package requires npm, Git, and a Node.js version matching `engines.node` in [packages/learning/package.json](packages/learning/package.json):
Copy file name to clipboardExpand all lines: docs/testing-and-review.md
+5-1Lines changed: 5 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -56,10 +56,14 @@ The [shared selection workflow](../.github/workflows/ci-changes.yml) calls [the
56
56
| Root contributor documents, shared and Hub guides, skills, and documentation assets | Neither |
57
57
| Workflow changes, selector changes, and unclassified paths | Both |
58
58
59
-
The workflows preserve the existing required check names; skipping an entire workflow with a path filter could leave those checks pending. Static jobs use job-level conditions. The four required Vitest shard jobs always expand their matrix and validate selection, but skip checkout, setup, and tests when Hub is unaffected. The required `Frontend tests`, `Production image`, and `Replica action tests` result jobs accept omitted work only after successful selection explicitly excluded it. The production-image matrix checks AMD64 and ARM64 independently without cancelling the other architecture on failure. Selection failures, invalid outputs, and failures in selected suites fail those result checks. Keep required-check configuration unchanged.
59
+
The workflows preserve the existing required check names; skipping an entire workflow with a path filter could leave those checks pending. Static jobs use job-level conditions. The Vitest shard jobs always expand their Node and shard matrix and validate selection, but skip checkout, setup, and tests when Hub is unaffected. The required `Frontend tests`, `Production image`, and `Replica action tests` result jobs accept omitted work only after successful selection explicitly excluded it. The frontend and build-action result jobs require every selected Node version to pass. The production-image matrix checks AMD64 and ARM64 independently without cancelling the other architecture on failure. Selection failures, invalid outputs, and failures in selected suites fail those result checks. Keep required-check configuration unchanged.
60
60
61
61
When adding a shared dependency or a new project, update the selector and its behavioral tests together. Unclassified paths deliberately run both suites until their dependencies are known. Run `node --test scripts/select-ci-suites.test.mjs` and `ruby scripts/check-ci-workflows.rb` from the repository root. The latter reads the actual workflow gates and checks their success, failure, cancellation, and missing-output behavior; both commands run before CI selects suites. Check changed workflows with `actionlint` when available. Actual job skipping and check reporting still need verification on GitHub after publishing.
62
62
63
+
Existing Node-dependent jobs in Hub, Starter, build-action, and Learning CI use a Node 24 and 26 matrix rather than a separate compatibility workflow. Each check keeps its existing name on Node 24 and adds a `(Node 26)` suffix on Node 26. A failure does not cancel the other version. npm installation enforces dependency engines, and `scripts/check-ci-workflows.rb` checks the supported ranges, matching lockfile metadata, and matrix wiring. These checks track the supported majors, not their exact minimum patch releases.
64
+
65
+
Ruby-only jobs, CI selection, and container builds retain their configured runtimes. The build-action suite tests its JavaScript and browser capture on both Node versions, but runs the composite-action smoke test only on Node 24: the composite action pins that runtime itself and uploads a single named artifact. Container and composite-action runtime defaults are unchanged.
66
+
63
67
## Update dependencies
64
68
65
69
Hub and the shared build action wait seven days before resolving newly published dependencies. npm enforces the delay through each project's committed `.npmrc`. Hub's RubyGems source in `Gemfile` applies the delay to Bundler. Dependabot applies the same cooldown to npm, Bundler, and GitHub Actions updates across the repository. The starter manages its dependency resolution independently.
0 commit comments