You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 534894c
Browse filesBrowse the repository at this point in the historyBrowse files
fix(gh-aw): restore hosted E2E and migrate package identity (#2410)
* fix(gh-aw): restore hosted E2E and migrate package identity
- The hosted E2E guard keys on the repository ID instead of the owner
name, so it runs again and fails loudly after any future rename
- github/squad/workflows becomes the canonical package identity; existing
bradygaster/squad/workflows installs still verify (exact allowlist),
and mixed or duplicate ownership records fail with guidance
- Install and upgrade docs check the revision's manifest before gh aw add
- uses: github/squad/.github/actions/squad-init (same pinned SHA); the
action's default release repository is github/squad
- Package regenerated with squad-install-verifier --write-source
Closes#2403
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): guard legacy-identity upgrade cleanup and migration warnings
Address two Copilot review findings on #2410.
Stop the upgrade before any cleanup when the forced reinstall fails. The
upgrade block in the gh-aw-enlistment skill, its four mirrors and the gh-aw
guide deleted the legacy
.github/aw/packages/bradygaster-squad-workflows-3632054824e8.json ownership
record even when `gh aw add --force` failed, leaving the previous
installation without its verification metadata. The block now stops with a
STOP message before removing anything. The verifier prints its recovery and
legacy-move commands as one && chain, so a failed reinstall stops them too,
and its staged-tree message says to delete the legacy record only after the
reinstall succeeds.
Allow the four squad-init replacement warnings only during the
legacy-identity migration. gh-aw v0.91.5 compares safe updates against the
locks committed at HEAD. While legacy locks are committed, every strict
compile, even after --approve, reports the bradygaster/squad -> github/squad
squad-init owner change once each in squad.md, squad-implement-worker.md,
squad-deps-worker.md and squad-retro.md (8 succeeded, 6 warnings), so the
two-warning gate stopped a valid migration before it could be committed. The
skill and the guide now allowlist exactly those four diagnostics and their
exact change list during that migration only. Any other warning, change,
duplicate or summary still stops the flow.
Tests run each upgrade block and the verifier's printed commands with a
failing and a succeeding stubbed `gh aw add`, and apply each document's
warning gate to real gh-aw v0.91.5 output from a repository with committed
legacy locks: with --approve, without it, and after the upgrade commit.
Mutation tests reject a widened migration allowlist.
Regenerate the package manifest and bootstrap verifier digest, and extend
the changeset.
Refs #2403
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): pin squad-init downloads and harden upgrade recovery
Address four Copilot review findings on #2410.
Pass `repository: 'github/squad'` to the pinned squad-init action. At
5c662ba its `repository` input still defaults to bradygaster/squad,
the source of the release archive, its SHA256SUMS checksum and the
latest-release lookup. The new `uses:` owner did not change that, and the
old path is now a fork with no releases, so whoever controls it would
supply both the archive and its checksum. Regenerate the four package
workflows and the integrity manifest.
Stop the guide's Upgrading block and the README install block on a
SQUAD_SHA that is not a 40-character lowercase commit SHA, before the
manifest contents API call, with the guard and message the other guide
blocks already use. The contents API accepts branch names, so `dev`
passed the identity check: the upgrade reinstalled and deleted the legacy
ownership record before --source-revision rejected it, and the README
block installed and pushed the moving ref. The skill and its mirrors were
already guarded.
Reject an exact ownership record next to a case-variant one. Reinstalling
GitHub/Squad/workflows as github/squad/workflows leaves both records,
because gh-aw names each by a digest of the identity as typed, and the
verifier used the exact one while ignoring the other. The error names
both records and the one to delete.
Run --materialize-runtime before `gh aw compile --strict` in the printed
recovery chain, as the documented install and upgrade sequences do.
`gh aw add --force` rewrites only the package-owned runtime copies, so a
stale or missing materialized file, such as .github/workflows/shared/squad.md,
failed verification again after a successful reinstall.
Tests resolve the activation step's squad-init inputs into the pinned-action
download harness, run every block that reads the manifest with
SQUAD_SHA=dev, verify an install with both records, and run the printed
recovery against a stale and a missing materialized file. Each fails with
its fix reverted.
Refs #2403
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): drop legacy install fallback, verify staged case variants
Revisions that declare only bradygaster/squad/workflows install the Squad
CLI through squad-init without a repository input, so activation downloads
the CLI and its checksum from bradygaster/squad. That repository is now a
separately controlled fork with no releases. Stop sending users there:
- The identity-gate STOP hint in the skill and its four mirrors, the guide
and the README now says to use a revision whose manifest declares
github/squad/workflows, or to ask the Squad maintainers for one, and
says why older revisions are not an option.
- Remove the instructions to install an older revision under the legacy
identity or stay on one from the skill, the guide, the README,
.github/agents.md and workflows/README.md, and the step-4 and
anti-pattern allowance for the legacy squad-init action name outside
the migration.
- The verifier still accepts existing bradygaster/squad/workflows installs
through its exact allowlist, and the documented legacy-to-canonical
upgrade is unchanged. Its notice now says the legacy identity is
accepted only so installations can move.
--verify-staged-install also missed a case-variant ownership record, such
as one for GitHub/Squad/workflows, that was deleted only from the working
tree. The index still held it, so a clean checkout of the commit failed
--verify-install. The staged check now lists .github/aw/packages/ one
level deep and rejects any staged record whose package is a case variant
of an accepted identity, naming its path. The step-7 deletion gate in the
skill, its mirrors and both guide gates admits exactly that deletion: a
.github/aw/packages/*.json record whose package at HEAD is a case variant.
Regenerate the integrity manifest and bootstrap digests for the verifier
and skill changes. Add a contract test that names file:line for any
install hint or STOP message that falls back to the legacy identity, gate
cases for the case-variant allowance, and a staged-verifier regression
test that also verifies a clean checkout.
Refs #2403
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): pass repository in squad-init examples, move ownership hints
Pinned squad-init revisions from before the action's default changed,
such as 5c662ba, still download the Squad CLI and its checksum from
bradygaster/squad, now a separately controlled fork. Changing the action
owner in a usage example does not change that default. Pass
repository: github/squad in the standalone-install example and in the
action.yml usage comment, the two examples that lacked it; the package
workflows already pass it. A new test scans every squad-init step in
tracked Markdown and YAML, including YAML comments, and names the
file:line of any that does not pass repository: github/squad.
The verifier's ownership diagnostics could steer users back to the
legacy identity. With an exact record beside a case-variant record, it
said to reinstall as the exact record's identity, which may be
bradygaster/squad/workflows. It now always recommends
github/squad/workflows and lists a legacy exact record for deletion
together with the case variants; a canonical exact record is kept. With
both exact identities present, it no longer offers to keep whichever
record matches the installed source bindings, which keeps the legacy
record while those bindings are still legacy.
Regenerate the integrity manifest and bootstrap digests for the verifier
change. The case-variant test now covers both the canonical and the
legacy exact record.
Refs #2403
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): one cleanup rule for extra Squad ownership records
When canonical, legacy and case-variant ownership records coexisted, the
verifier's advice left out the case variant, so following it still
failed verification. A duplicate exact-identity record at a path gh-aw
does not write got the computed legacy path instead of its own.
findOwnershipRecord now applies one rule whenever more than one Squad
record is found: it lists every record with its path and package, then
says to delete every listed path except
.github/aw/packages/github-squad-workflows-23a7638f599e.json after
reinstalling as github/squad/workflows, because that reinstall writes
exactly that record. The case-only hint uses the same rule, and records
are read in sorted order so the advice is stable on every platform.
The staging gate matches the advice. The skill's step-7 gate, its four
mirrors and both guide gates replace the separate legacy-path allowance
and the case-variant predicate with one rule. A staged deletion of
.github/aw/packages/<name>.json passes only if it is not the canonical
destination, its HEAD content is JSON, and its package, lowercased, is
github/squad/workflows or bradygaster/squad/workflows. The router
allowance is unchanged. --verify-staged-install now rejects any
still-indexed Squad record other than the verified one, not only case
variants.
Regenerate the integrity manifest and bootstrap verifier digests.
Refs #2403
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update the shipped gh-aw-enlistment skill for the repository's new home, `github/squad`. It now installs the gh-aw package as `github/squad/workflows`, links to the docs guide's new address, and allowlists the `github/squad/.github/actions/squad-init` action. Before installing or upgrading, it checks that the chosen Squad revision declares `github/squad/workflows` in its package manifest, and stops otherwise. It no longer suggests installing an older revision as `bradygaster/squad/workflows`, because such revisions download the Squad CLI from the separately controlled `bradygaster/squad` fork. It also explains how to move an installation off that legacy identity, which the install verifier accepts only so that existing installations can move. That upgrade stops before removing anything if the forced reinstall fails, and until it is committed, its strict compile gate accepts only the four expected squad-init owner-replacement warnings. Its staging gate also permits deleting any other Squad ownership record the install verifier tells you to delete, such as a duplicate or case-variant record, but never the `github/squad/workflows` record that gh-aw writes.
echo"STOP: cannot read workflows/squad-workflows.manifest.json from github/squad at ${SQUAD_SHA}.">&2
203
+
echo"Check gh auth status --hostname github.com and network access, and confirm SQUAD_SHA is a github/squad commit that has this manifest, then retry.">&2
204
+
else
205
+
echo"STOP: Squad ${SQUAD_SHA} does not declare the github/squad/workflows package (found '${squad_package}').">&2
206
+
echo"Use a revision whose manifest declares github/squad/workflows, or ask the Squad maintainers for one. Older revisions download the Squad CLI from the bradygaster/squad fork, which has no releases.">&2
207
+
fi
208
+
exit 1
209
+
}
210
+
# squad-package-identity-end
211
+
gh aw add "github/squad/workflows@${SQUAD_SHA}"
197
212
rm -f .github/skills/agentic-workflows/SKILL.md
198
213
```
199
214
215
+
`github/squad/workflows` verifies only at Squad revisions whose
echo"STOP: cannot read workflows/squad-workflows.manifest.json from github/squad at ${SQUAD_SHA}.">&2
289
+
echo"Check gh auth status --hostname github.com and network access, and confirm SQUAD_SHA is a github/squad commit that has this manifest, then retry.">&2
290
+
else
291
+
echo"STOP: Squad ${SQUAD_SHA} does not declare the github/squad/workflows package (found '${squad_package}').">&2
292
+
echo"Use a revision whose manifest declares github/squad/workflows, or ask the Squad maintainers for one. Older revisions download the Squad CLI from the bradygaster/squad fork, which has no releases.">&2
293
+
fi
294
+
exit 1
295
+
}
296
+
gh aw add "github/squad/workflows@${SQUAD_SHA}" --force || {
297
+
echo"STOP: gh aw add --force failed, so this block removed nothing. Fix the error above, then rerun the block.">&2
echo"STOP: cannot read workflows/squad-workflows.manifest.json from github/squad at ${SQUAD_SHA}.">&2
650
+
echo"Check gh auth status --hostname github.com and network access, and confirm SQUAD_SHA is a github/squad commit that has this manifest, then retry.">&2
651
+
else
652
+
echo"STOP: Squad ${SQUAD_SHA} does not declare the github/squad/workflows package (found '${squad_package}').">&2
653
+
echo"Use a revision whose manifest declares github/squad/workflows, or ask the Squad maintainers for one. Older revisions download the Squad CLI from the bradygaster/squad fork, which has no releases.">&2
654
+
fi
655
+
exit 1
656
+
}
657
+
gh aw add "github/squad/workflows@${SQUAD_SHA}"
502
658
rm -f .github/skills/agentic-workflows/SKILL.md
503
659
504
660
# Safe-update report shows ONLY the two documented secrets + squad-init → approve once
@@ -566,13 +722,14 @@ gh pr merge --squash # auto-merge before human review. NEVER.
566
722
`.github/skills/agentic-workflows/SKILL.md`; keep the exact Squad-owned
567
723
`.github/skills/gh-aw-enlistment/SKILL.md`.
568
724
- ❌ **Approving unknown safe updates.** Approve ONLY `SQUAD_GITHUB_APP_PRIVATE_KEY`,
569
-
`SQUAD_GITHUB_TOKEN`, and `bradygaster/squad/.github/actions/squad-init`. Anything
725
+
`SQUAD_GITHUB_TOKEN`, and `github/squad/.github/actions/squad-init`. Anything
570
726
else is a STOP.
571
727
- ❌ **Treating `--approve` as the final compile.** Always finish with a plain
572
728
`gh aw compile --strict` (no `--approve`).
573
729
- ❌ **Tolerating extra warnings.** Only the documented `squad-review.md`
574
-
`pull_request_target` advisory and `squad.md` bot-trigger warning are allowed;
575
-
every other warning or error halts the run.
730
+
`pull_request_target` advisory and `squad.md` bot-trigger warning are allowed,
731
+
plus step 5's four squad-init replacement warnings during the legacy-identity
732
+
migration only; every other warning or error halts the run.
576
733
- ❌ **Committing diagnostics.** Never commit `.github/aw/logs/` output; add the
577
734
log `.gitignore` if missing.
578
735
- ❌ **Clobbering existing workflows.** The install is additive; preserve unrelated
0 commit comments