Repository navigation
Commit d1b3fe4
fix(test): raise Aspire dashboard health-check timeout to absorb CI runner contention (#2132)
* fix(test): pin Aspire dashboard image to verified-good 13.5.2 build
Root cause of the #2123/#2132 Aspire integration test CI failures was
NOT CPU contention: `mcr.microsoft.com/dotnet/aspire-dashboard:latest`
(and the major-version tag `:13`, confirmed to currently resolve to
the identical freshly-published `13.6.0` build/digest) is broken — the
container exits immediately (exitCode=145) because
/app/Aspire.Dashboard.dll is missing from the image, so the dashboard
health check can never succeed no matter the timeout.
Fix: pin docker pull/run to `:13.5.2`, a distinct ~3-week-older build
(different layer digests, verified via the MCR manifest API) that
predates the broken `13.6.0` release and does not exhibit the
missing-DLL problem.
Diagnostics hardening made while chasing this down (kept, as they are
independently valuable for any future flake in this suite):
- Removed --rm from the dashboard `docker run` so a crashed container
survives long enough for failure-path `docker inspect`/`docker logs`
diagnostics to run (relying on existing explicit removeContainer()
cleanup instead).
- Captured container stderr in the `docker logs` diagnostics call
(`2>&1`), since .NET unhandled-exception output goes to stderr and
was previously silently dropped, hiding the real crash reason.
- Raised isDockerAvailable()'s `docker info` timeout from 5s to 20s to
prevent false-skip of the whole Docker-dependent suite under CI CPU
contention (which would otherwise look like a false pass).
- Raised the dashboard health-check timeout to 120s as defense-in-depth
against genuine contention-induced slow starts, independent of the
image-pinning fix above.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(test): widen beforeAll hook budget for diagnostics margin
Addresses reviewer feedback on PR #2132:
- The 240s beforeAll hook budget had zero margin above the bounded
120s docker-pull timeout + 120s health-check timeout, so Vitest
could abort the hook with a generic timeout before
waitForHealthy's more informative crash diagnostics could be
thrown. Widened to 300s (~60s margin for container startup,
diagnostics collection, and Playwright browser launch).
- The --rm-vs-diagnostics concern on the same thread was already
resolved in a prior commit (docker run no longer passes --rm);
no further change needed there.
Also trims two overly verbose/speculative inline comments (image-pin
rationale, health-check rationale) down to the essential facts.
Closes #2133
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: brady gaster <bradygaster@github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>1 parent 10a8931 commit d1b3fe4
2 files changed
Lines changed: 49 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
39 | 46 | | |
40 | 47 | | |
41 | 48 | | |
42 | 49 | | |
43 | 50 | | |
44 | 51 | | |
45 | | - | |
| 52 | + | |
46 | 53 | | |
47 | 54 | | |
48 | 55 | | |
| |||
53 | 60 | | |
54 | 61 | | |
55 | 62 | | |
56 | | - | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
57 | 81 | | |
58 | 82 | | |
59 | 83 | | |
| |||
122 | 146 | | |
123 | 147 | | |
124 | 148 | | |
125 | | - | |
| 149 | + | |
126 | 150 | | |
127 | | - | |
| 151 | + | |
128 | 152 | | |
129 | 153 | | |
130 | 154 | | |
131 | | - | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
132 | 161 | | |
133 | 162 | | |
134 | | - | |
| 163 | + | |
135 | 164 | | |
136 | 165 | | |
137 | 166 | | |
138 | | - | |
| 167 | + | |
139 | 168 | | |
140 | 169 | | |
141 | 170 | | |
142 | 171 | | |
143 | | - | |
144 | | - | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
145 | 176 | | |
146 | 177 | | |
147 | 178 | | |
148 | 179 | | |
149 | 180 | | |
150 | 181 | | |
151 | | - | |
| 182 | + | |
152 | 183 | | |
153 | 184 | | |
154 | 185 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
17 | 24 | | |
18 | 25 | | |
19 | 26 | | |
| |||
0 commit comments