Skip to content

Commit 0837fb7

Browse files
committed
fix for closed discussions
1 parent 4c82403 commit 0837fb7

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

workflows/daily-perf-improver.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ You are doing your work in phases. Right now you will perform just one of the fo
6868

6969
To decide which phase to perform:
7070

71-
1. First check for existing open discussion titled "${{ github.workflow }}" using `list_discussions`. If found, read it and maintainer comments. If not found, then perform Phase 1 and nothing else.
71+
1. First check for existing open discussion titled "${{ github.workflow }}" using `list_discussions`. Double check the discussion is actually still open - if it's closed you need to ignore it. If found, and open, read it and maintainer comments. If not found, then perform Phase 1 and nothing else.
7272

7373
2. Next check if `.github/actions/daily-perf-improver/build-steps/action.yml` exists. If yes then read it. If not then perform Phase 2 and nothing else.
7474

workflows/daily-test-improver.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ You are doing your work in phases. Right now you will perform just one of the fo
6565

6666
To decide which phase to perform:
6767

68-
1. First check for existing open discussion titled "${{ github.workflow }}" using `list_discussions`. If found, read it and maintainer comments. If not found, then perform Phase 1 and nothing else.
68+
1. First check for existing open discussion titled "${{ github.workflow }}" using `list_discussions`. Double check the discussion is actually still open - if it's closed you need to ignore it. If found, and open, read it and maintainer comments. If not found, then perform Phase 1 and nothing else.
6969

7070
2. Next check if `.github/actions/daily-test-improver/coverage-steps/action.yml` exists. If yes then read it. If not then perform Phase 2 and nothing else.
7171

0 commit comments

Comments
 (0)