Skip to content

Commit 62799e0

Browse files
authored
Apply GitHub iconography to workshop diagrams (#2456)
1 parent e4c23ef commit 62799e0

7 files changed

Lines changed: 69 additions & 25 deletions

‎scripts/check-svg-visual-language.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
* Checks:
1212
* 1. Accessibility — root <svg> must have role="img" and a non-empty,
1313
* resolvable accessible name.
14-
* 2. Icon characters — Unicode status/icon characters (✓ ✗ ✕ ⚡ 🕐 ▶ ►)
14+
* 2. Icon characters — Unicode status/icon characters (✓ ✗ ✕ ⚡ ⏰ 🕐 ▶ ►)
1515
* must not appear in SVG <text> nodes used as visual indicators.
1616
* Use unmodified Primer Octicon paths instead (see guidelines).
1717
* 3. Canvas dimensions — light/dark variant files (*-light.svg, *-dark.svg)
@@ -148,6 +148,7 @@ const ICON_CHARS = {
148148
'✕': 'the unmodified x-circle Octicon path',
149149
'✘': 'the unmodified x-circle Octicon path',
150150
'⚡': 'the unmodified zap Octicon path',
151+
'⏰': 'the unmodified clock Octicon path',
151152
'🕐': 'the unmodified clock Octicon path',
152153
'🕛': 'the unmodified clock Octicon path',
153154
'▶': 'the unmodified play Octicon path',

‎scripts/check-svg-visual-language.test.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,11 +104,13 @@ test('rejects Unicode indicators and incorrect explicit state colors', () => {
104104
role="img" aria-label="Bad state">
105105
<rect data-state="error" fill="#3fb950" />
106106
<text>✓</text>
107+
<text>⏰</text>
107108
</svg>`
108109
);
109110

110111
assert.equal(result.status, 1);
111112
assert.match(result.stderr, /Unicode icon character/);
113+
assert.match(result.stderr, /"⏰"/);
112114
assert.match(result.stderr, /data-state="error"/);
113115
assert.match(result.stderr, /Expected Primer dark-mode color: #f85149/);
114116
});

‎workshop/images/00-actions-vs-agentic-dark.svg‎

Lines changed: 5 additions & 2 deletions
Loading

‎workshop/images/00-actions-vs-agentic-light.svg‎

Lines changed: 5 additions & 2 deletions
Loading

‎workshop/images/00-actions-vs-agentic.svg‎

Lines changed: 5 additions & 2 deletions
Loading

‎workshop/images/14-workflow-architecture-dark.svg‎

Lines changed: 25 additions & 9 deletions
Loading

0 commit comments

Comments
 (0)