Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debt: unify repository/branch/pr open workflows into common place #3626

Open
axosoft-ramint opened this issue Sep 27, 2024 · 0 comments
Open
Assignees
Labels
debt Technical debt
Milestone

Comments

@axosoft-ramint
Copy link
Contributor

Flows from launchpad, launchpad view, PR view, etc. all go through different flows for getting to targets. Deep link service, pullRequest.ts, openOrCreateWorktree.ts for the PR extension, all have different ways of getting to a target repository, locating if needed, adding remote, fetching, etc. and ultimately getting to the target (PR branch, branch, commit, etc.).

All of this very-similar logic should be unified in one place, and everything should go through the common logic.

pullRequest.ts is a good model since it leverages virtual repo opening and other tricks to locate the repo.

@axosoft-ramint axosoft-ramint added this to the 16.0 milestone Sep 27, 2024
@axosoft-ramint axosoft-ramint added the debt Technical debt label Sep 27, 2024
@axosoft-ramint axosoft-ramint changed the title Unify repository/branch/pr open workflows into common place Debt: unify repository/branch/pr open workflows into common place Sep 27, 2024
@axosoft-ramint axosoft-ramint self-assigned this Oct 29, 2024
@eamodio eamodio modified the milestones: 16.0, 16.1 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Technical debt
Projects
None yet
Development

No branches or pull requests

2 participants