tool-vnc (workspace-full-vnc) needs some patches for adapting with new Ubuntu Jammy

[axonasif]

Bug description

• /tmp/.X0-lock is no longer being created by the updated display server, but the vnc startup script checks for it's existence to determine if the vnc server is already running¹. Because of that, the startup script is executed for every new terminal even if vnc is running. Also a race condition may exist now when you have many supervisor tasks since the IDE process doesn't start with the login shell anymore for performance reasons (not related with Jammy).
• Upon opening Google chrome, it prompts for a keyring password, not sure if this was the case in Focal, some packages probably changed their config.

Steps to reproduce

• Open https://github.com/gitpod-io/website on Gitpod
• Notice that all .gitpod.yml task terminals are trying to start the vnc server.

Expected behavior

gp-vncsession script should only run in one place at a time (ideally the first terminal created). And there should be no race conditions.

Additionally, chrome should not prompt for a keyring password since it's not helpful in the context of Gitpod and can break some automations from .gitpod.yml tasks.

Example repository

No response

Anything else?

gitpod/workspace-full-vnc is not broken on Jammy, it works, but it might have some race condition and unexpected restarts of the vnc server.

Front conversations

https://gitpod.slack.com/archives/C02P236JZPC/p1687448446860189

Footnotes

1. https://github.com/gitpod-io/workspace-images/blob/5530267b5da00c49be537ddfd8740b99daeaf217/chunks/tool-vnc/gp-vncsession#L16 ↩