From f62df523e0121ddead413da6d6eaf944a39c74e5 Mon Sep 17 00:00:00 2001 From: Eliah Kagan Date: Tue, 12 Dec 2023 09:15:19 -0500 Subject: [PATCH] Remove TestSubmodule.test_rename xfail mark This is to clearly establish the failure still occurs (since we do not have strict=True set). It is in preparation for working around the problems with a call to gc.collect(). See 82c361e and 0b7ee17 for context. --- test/test_submodule.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/test/test_submodule.py b/test/test_submodule.py index 852a5ef6f..e2380d522 100644 --- a/test/test_submodule.py +++ b/test/test_submodule.py @@ -948,18 +948,6 @@ def test_remove_norefs(self, rwdir): sm.remove() assert not sm.exists() - @pytest.mark.xfail( - os.name == "nt" and sys.version_info >= (3, 12), - reason=( - "The sm.move call fails. Submodule.move calls os.renames, which raises:\n" - "PermissionError: [WinError 32] " - "The process cannot access the file because it is being used by another process: " - R"'C:\Users\ek\AppData\Local\Temp\test_renamekkbznwjp\parent\mymodules\myname' " - R"-> 'C:\Users\ek\AppData\Local\Temp\test_renamekkbznwjp\parent\renamed\myname'" - "\nThis resembles other Windows errors, but only occurs starting in Python 3.12." - ), - raises=PermissionError, - ) @with_rw_directory def test_rename(self, rwdir): parent = git.Repo.init(osp.join(rwdir, "parent"))