-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release New Version to PyPi #51
Comments
Thanks for the hint. There are no improvements, just different declarations of compatible python versions. Now that I think about it, it would certainly be better to keep stating compatibility to EOL versions of python as the library is indeed compatible to a lot of these. Oh well, something to fix another day. https://pypi.org/project/smmap/6.0.0/ @EliahKagan I remember mentioning that it's probably better, i.e. more compatible, to declare all python versions that a library is actually compatible with, instead of removing EOL python versions out of principle. Now that I have released another major release of |
I've opened #52 for this. It adds back 3.7 support and is analogous to gitpython-developers/gitdb#94. One reason I consider it worthwhile to fix this is to that other projects that support the range 3.7-3.12 can pin a single specific version that will work and is documented to work. However, if the only thing that had to be done to support newer versions was adding classifiers for them, and they actually worked before (since classifiers aren't needed to permit installation), and nothing else was changed, then either a 6.0.1 could be released or 6.0.0 could be yanked, I suppose. @Byron This reminds me of something I had been meaning to ask you, which How is If the purpose of using submodules was just to allow the dependency to be edited, I think that may not justify their use. |
Oh, I see. In __version__ = "git"
# { Initialization
def _init_externals() -> None:
"""Initialize external projects by putting them into the path"""
if __version__ == "git" and "PYOXIDIZER" not in os.environ:
sys.path.insert(1, osp.join(osp.dirname(__file__), "ext", "gitdb"))
try:
import gitdb
except ImportError as e:
raise ImportError("'gitdb' could not be found in your PYTHONPATH") from e
# END verify import
# } END initialization Putting it early in I wonder if we can stop doing that, though. I think testing GitPython with its actual dependencies like it gets them "in the wild" is valuable, and |
Thanks for chiming in! I think it makes sense to yank v6.0 and release a 6.0.1 to open the version range. There wouldn't have been the need for a 6.0 in the first place, so I guess I can make it 5.0.1 as well and there is less work for everyone. Here is the new release: https://pypi.org/project/smmap/5.0.1/ . About submodulesIndeed, submodules are a relic of the past where |
It turns out the code in |
Hello,
Do you have any plans to release a new version to PyPi
https://pypi.org/project/smmap/#history
Both the PyPi version & Conda-forge version are quite outdated - Version 5.0 October 2021.
Thank You and Regards,
The text was updated successfully, but these errors were encountered: