Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMT vs Local time #18

Open
Tracked by #19
fsnlarson opened this issue Oct 7, 2016 · 17 comments
Open
Tracked by #19

GMT vs Local time #18

fsnlarson opened this issue Oct 7, 2016 · 17 comments

Comments

@fsnlarson
Copy link

screen shot 2016-10-07 at 3 20 01 pm

This should be an option for the CLI tool perhaps since it's possible in the web GUI?

@giuse88
Copy link
Owner

giuse88 commented Oct 11, 2016

true. I am using UTC time in duka, I can look into implementing it ;)

@kavuraki
Copy link

Many thanks for the tool.
Any possible progress on this?

@giuse88
Copy link
Owner

giuse88 commented Nov 27, 2016

I haven't started working on it yet. I am planning to fix these issues in a week ;) I've been quite busy recently :(

@giuse88 giuse88 mentioned this issue Nov 27, 2016
5 tasks
@giuse88
Copy link
Owner

giuse88 commented Nov 27, 2016

@gobbluth @kavuraki What do you think if I add a new command line option like :

--local-time          use local time (default GMT)

giuse88 added a commit that referenced this issue Nov 27, 2016
@giuse88
Copy link
Owner

giuse88 commented Nov 27, 2016

Check out Pull request : #19

I am converting the timestamp to the local timezone. Is this what you want?

@kavuraki
Copy link

@giuse88
So in this case can I enter the local timezone manually?

@giuse88
Copy link
Owner

giuse88 commented Nov 28, 2016

@kavuraki
No, if you select local, it converts the timestamp to your local timezone.

@kavuraki
Copy link

@giuse88 that's great. It works for me!

@giuse88
Copy link
Owner

giuse88 commented Nov 28, 2016

@kavuraki Cool! Do you think you can try the code in this branch? It works for me but I live in the GMT timezone. Thus, there is no difference between GMT and local. Testing timezone is quite annoying, if it works for you, I will release it today.

@kavuraki
Copy link

kavuraki commented Nov 28, 2016

@giuse88 what should I set for the variable? nothing? is it "True"?

duka EURUSD -s 2016-10-15 -e 2016-11-28 -c D1 --local-time

@giuse88
Copy link
Owner

giuse88 commented Nov 28, 2016

@kavuraki That should just work! It s a boolean value

@kavuraki
Copy link

@giuse88 D1 data still start from 03:00 since I live in UTC+3

Maybe it's not the place btw I get csv files one empty row between each rows.

@giuse88
Copy link
Owner

giuse88 commented Nov 29, 2016

Can you upload the file here?
You're getting the same data you would get without local-time. The only difference is that now the data timestamp is converted to your local time. Is this what you wanted?

@kavuraki
Copy link

In this case I got confused. Cause I notice that some days are twice in the table.

duka EURUSD -s 2016-10-15 -e 2016-11-28 -c D1

duka EURUSD -s 2016-10-15 -e 2016-11-28 -c D1 --local-time

Please find attached output files for the commands above.

outputs.zip

From Dukascopy If I select "local" the day starts from 0:00 (it's 21:00 in UTC which is 0:00 in UTC+3)

@giuse88
Copy link
Owner

giuse88 commented Nov 29, 2016

@kavuraki Thanks for your help. ;) I am looking into it..

@giuse88
Copy link
Owner

giuse88 commented Dec 4, 2016

Yes, I identify the problem you are having. It's caused by daylight time change :( ... It is not related to the local change I made. However, I am not satisfied with the local change. A proper change requires a big refactor and I have no time right now, so I am going to revert this change and merge the rest.

@taewookim
Copy link

Any updates on this?

evianzhow pushed a commit to evianzhow/duka that referenced this issue Aug 8, 2017
thomasf1 added a commit to thomasf1/duka that referenced this issue Dec 10, 2019
* commit 'b2a20917101bc94a31d21047db130eb92e5b9787':
  Add timezone info to the file name.
  Fix variable name
  Update Help message
  Added travis
  Fix unit tests
  Add local time Fix giuse88#18
  Fix candles help string issue giuse88#17

# Conflicts:
#	.travis.yml
#	README.md
#	duka/app/app.py
#	duka/core/csv_dumper.py
#	duka/core/processor.py
#	duka/main.py
#	requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants