-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMT vs Local time #18
Comments
true. I am using UTC time in duka, I can look into implementing it ;) |
Many thanks for the tool. |
I haven't started working on it yet. I am planning to fix these issues in a week ;) I've been quite busy recently :( |
Check out Pull request : #19 I am converting the timestamp to the local timezone. Is this what you want? |
@giuse88 |
@kavuraki |
@giuse88 that's great. It works for me! |
@kavuraki Cool! Do you think you can try the code in this branch? It works for me but I live in the GMT timezone. Thus, there is no difference between GMT and local. Testing timezone is quite annoying, if it works for you, I will release it today. |
@giuse88 what should I set for the variable? nothing? is it "True"?
|
@kavuraki That should just work! It s a boolean value |
@giuse88 D1 data still start from 03:00 since I live in UTC+3 Maybe it's not the place btw I get csv files one empty row between each rows. |
Can you upload the file here? |
In this case I got confused. Cause I notice that some days are twice in the table.
Please find attached output files for the commands above. From Dukascopy If I select "local" the day starts from 0:00 (it's 21:00 in UTC which is 0:00 in UTC+3) |
@kavuraki Thanks for your help. ;) I am looking into it.. |
Yes, I identify the problem you are having. It's caused by daylight time change :( ... It is not related to the local change I made. However, I am not satisfied with the local change. A proper change requires a big refactor and I have no time right now, so I am going to revert this change and merge the rest. |
Any updates on this? |
* commit 'b2a20917101bc94a31d21047db130eb92e5b9787': Add timezone info to the file name. Fix variable name Update Help message Added travis Fix unit tests Add local time Fix giuse88#18 Fix candles help string issue giuse88#17 # Conflicts: # .travis.yml # README.md # duka/app/app.py # duka/core/csv_dumper.py # duka/core/processor.py # duka/main.py # requirements.txt
This should be an option for the CLI tool perhaps since it's possible in the web GUI?
The text was updated successfully, but these errors were encountered: