Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing ToQuaternion #6

Open
gkjohnson opened this issue Dec 5, 2017 · 0 comments
Open

Consider removing ToQuaternion #6

gkjohnson opened this issue Dec 5, 2017 · 0 comments

Comments

@gkjohnson
Copy link
Owner

ToQuaternion basically only works with properly with Unity-frame axes because we have to assume certain conventions when pulling the new rotation order out of the axis.

There even seem to be subtle rotation offsets when consistently converting to a different frame like XYZ instead of XY-Z. Possibly because the euler application for quaternions assumes the axis conventions? This should be investigated (the problem can be seen when rotating like in the example image)

Either way, it might make things less confusing if it wasn't there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant