Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank URL bar on new tab #2

Closed
kmjennison opened this issue Apr 14, 2017 · 0 comments
Closed

Blank URL bar on new tab #2

kmjennison opened this issue Apr 14, 2017 · 0 comments
Assignees
Labels

Comments

@kmjennison
Copy link
Contributor

kmjennison commented Apr 14, 2017

We previously iframed the Tab for a Cause page within Chrome's internal new tab page, which allowed the cursor to focus on an empty omnibar (as it does in the default new tab). However, many users could not whitelist their ad blockers because the top frame's domain was chrome://extension/... instead of tab.gladly.io. Because ad revenue is central to Tab for a Cause's charitable mission, we recently changed this behavior to explicitly open the Tab for a Cause webpage, which allows users to whitelist their ad blockers.

Redirecting to the website URL is subpar: it feels slower, and it sometimes interrupts users typing their next URL. Unfortunately, Chrome extensions don't have direct control over the omnibar (e.g., see this discussion).

A potential solution for this could be:

  1. The extension overrides the Chrome new tab page and uses an iframe, as it previously did.
  2. The web page detects ad blocking; when we message users to ask them to whitelist the site on their ad blocker, redirect from the Chrome new tab page to a top-level tab.gladly.io to allow easy whitelisting.
  3. After whitelisting, continue to open the tab in an iframe.

We first need to confirm that major ad blockers allow ads in the chrome://extension page after whitelisting tab.gladly.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant