glass namespace contains unwanted symbols

[ntessore]

Describe the Bug

These add noise to the glass namespace:

import contextlib
from importlib.metadata import PackageNotFoundError

with contextlib.suppress(PackageNotFoundError):
    from ._version import __version__, __version_tuple__

and try: ... catch ImportError: pass should work just as well?

To Reproduce

import glass
print(glass.contextlib, glass.PackageNotFoundError)

Expected Behaviour

Not have contextlib and PackageNotFoundError in the glass namespace.

Actual Behaviour

Have contextlib and PackageNotFoundError in the glass namespace.

Version In Use

2024.3

Additional Context

[Saransh-cpp]

We should actually not be suppressing that error, instead we should let import glass fail if . _version.__version__ is not present.

[ntessore]

I think we need to suppress the import error since the _version isn't generated unless the code is installed, e.g., on git clone.

[Saransh-cpp]

I see, usually it is not recommended to import a package without installing it, but we can switch to try-except if that is a use-case. I believe contextlib was used to follow suggestions from ruff. No strong opinions on polluting the namespace, but usually it is okay to have such imports in __init__.py (and not include them in __all__).

[ntessore]

To be fair, it's been a while since I used package.__version__ now that importlib.metadata.version() is available out of the box. Perhaps the import isn't even necessary?