Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: When auto adding import, if it's the first import, a blank line should follow it #3271

Open
johtso opened this issue Jun 12, 2024 · 2 comments
Open

LSP: When auto adding import, if it's the first import, a blank line should follow it #3271

johtso opened this issue Jun 12, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Contributions encouraged priority:medium
Milestone
LS02

Comments

@johtso
Copy link

johtso commented Jun 12, 2024

With the new tab completion auto adding of imports, if it's the first import in the file, there's no blank line between it and the first line of code.
@johtso johtso added the bug Something isn't working label Jun 12, 2024
@lpil
Copy link
Member

lpil commented Jun 13, 2024

Good idea. Thanks!

@lpil lpil added help wanted Contributions encouraged good first issue Good for newcomers priority:medium labels Jun 13, 2024
@lpil lpil added this to the LS02 milestone Jun 13, 2024
codemonkey76 added a commit to codemonkey76/gleam that referenced this issue Jun 14, 2024
@codemonkey76
Add blank line following when auto importing as first import, gleam-l…
52eb910 
…ang#3271
@codemonkey76
Copy link

I've had a go at this, see #3277

codemonkey76 added a commit to codemonkey76/gleam that referenced this issue Jun 21, 2024
@codemonkey76
Implemented extra newline after first import Issue gleam-lang#3271
485b23d
@Zhomart Zhomart mentioned this issue Jun 23, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Contributions encouraged priority:medium
Projects
Gleam Language Server
Status: Unfinished
Milestone
LS02
Development

No branches or pull requests
3 participants
@johtso @codemonkey76 @lpil