Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LS rename doesn't work in Zed #4201

Open
lpil opened this issue Jan 26, 2025 · 2 comments · May be fixed by #4203
Open

LS rename doesn't work in Zed #4201

lpil opened this issue Jan 26, 2025 · 2 comments · May be fixed by #4203
Labels
bug Something isn't working help wanted Contributions encouraged priority:high

Comments

@lpil
Copy link
Member

lpil commented Jan 26, 2025

Image

Here's what I get in Zed when I use it (by pressing F2).

I don't know what this means. It works in Neovim.

@lpil lpil added bug Something isn't working help wanted Contributions encouraged priority:high labels Jan 26, 2025
@GearsDatapacks
Copy link
Member

Yeah so there are a few different responses you can return when the user presses the rename button. They basically describe the range that is highlighted and the placeholder text for the rename prompt. Currently, we just return a response which basically says "it's up to the client to figure this out, just perform the default behaviour." Which I guess isn't an option the zed supports. We can fix this by providing explicit behaviour rather than relying on the default.
This should be a pretty easy fix, I'll do it when I get home

@lpil
Copy link
Member Author

lpil commented Jan 26, 2025

Huh! I'm surprised that Zed errors in that case

@GearsDatapacks GearsDatapacks linked a pull request Jan 26, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Contributions encouraged priority:high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants