Prism: Relative keys not supported in partial ERB (#665)

Author: davidwessman

lib/i18n/tasks/scanners/prism_scanners/nodes.rb

@@ -33,8 +33,12 @@ def rails_view?
       rails && file_path.present? && file_path.include?("app/views/")
     end
 
+    def partial_view?
+      file_path.present? && File.basename(file_path).start_with?("_")
+    end
+
     def support_relative_keys?
-      rails_view?
+      rails_view? && !partial_view?
     end
 
     def path

spec/fixtures/used_keys/app/views/application/_event.html.erb

@@ -0,0 +1,9 @@
+I18n.t("this_should_not")
+<h2>
+  <% # i18n-tasks-use t('comment.absolute.attribute') %>
+  <%= Translate.absolute.attribute %>
+  <%= MeetingNote.model_name.human(count: 1) %>
+  <%= AgendaItem.human_attribute_name(:title) %>
+</h2>
+
+<%= t(".cannot_resolve_relative") %>

spec/used_keys_erb_prism_spec.rb

@@ -446,4 +446,74 @@
       end
     end
   end
+
+  describe "partials" do
+    let(:paths) { %w[app/views/application/_event.html.erb] }
+
+    it "does not allow relative keys in partials" do
+      used_keys = task.used_tree
+      expect(used_keys.size).to eq(1)
+      leaves = used_keys.leaves.to_a
+      leaves_as_hash = leaves_to_hash(leaves)
+      expect(leaves_as_hash.keys).to match_array(
+        %w[
+          activerecord.attributes.agenda_item.title
+          activerecord.models.meeting_note.one
+          comment.absolute.attribute
+        ]
+      )
+
+      expect_node_key_data(
+        leaves[0],
+        "comment.absolute.attribute",
+        occurrences:
+          make_occurrences(
+            [
+              {
+                path: "app/views/application/_event.html.erb",
+                pos: 35,
+                line_num: 3,
+                line_pos: 5,
+                line: "  <% # i18n-tasks-use t('comment.absolute.attribute') %>",
+                raw_key: "comment.absolute.attribute"
+              }
+            ]
+          )
+      )
+      expect_node_key_data(
+        leaves[1],
+        "activerecord.models.meeting_note.one",
+        occurrences:
+          make_occurrences(
+            [
+              {
+                path: "app/views/application/_event.html.erb",
+                pos: 132,
+                line_num: 5,
+                line_pos: 7,
+                line: "  <%= MeetingNote.model_name.human(count: 1) %>",
+                raw_key: "activerecord.models.meeting_note.one"
+              }
+            ]
+          )
+      )
+      expect_node_key_data(
+        leaves[2],
+        "activerecord.attributes.agenda_item.title",
+        occurrences:
+          make_occurrences(
+            [
+              {
+                path: "app/views/application/_event.html.erb",
+                pos: 180,
+                line_num: 6,
+                line_pos: 7,
+                line: "  <%= AgendaItem.human_attribute_name(:title) %>",
+                raw_key: "activerecord.attributes.agenda_item.title"
+              }
+            ]
+          )
+      )
+    end
+  end
 end