-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement sample weights to allow use on weighted data #279
Comments
Feel free to open a WIP pull request so that it's not too much to review in one go |
tricky thing there is that the branch is built as a "fork of pyglmnet that does things the way I need them done" rather than a "prepping for a PR", and it includes additional logging along with the sample weights, so it probably wouldn't be possible to merge directly. It does have tests and updated documentation and everything, though. |
okay I see, whenever you are ready. It's usually a good idea to open PR earlier than later so that it's possible to discuss and change things while there isn't too much code. |
It's unfortunate that the original user account on this request was deleted. I would also be interested in this feature. |
it's here: #324 I am happy to review/help if you want to try and finish this work ... however it's unlikely to be on the top of my priority list at the moment |
Oh great! I will see if I can carve out some time to contribute to this. |
keep us posted! |
Proof-of concept is in https://github.com/peterfoley605/pyglmnet/tree/implement_sample_weight
The text was updated successfully, but these errors were encountered: