-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media Cloud Image does not appear in exported html #14
Comments
@sapraaman is it possible to add the URL of the image beneath the inserted image. maybe this will help our other issues. because when you add an image directly to etherpad from outside the platform, it does this. |
@connieimdialog if I drag/drop image from outside browser into etherpad window, image gets displayed. Now when I export to html using arrows button, I see "*" in place of image, and I don't see any url. When you say "when you add an image directly to etherpad from outside the platform, it does this.", what are the steps you are following ? And there is no url of the image when we generate it from DOM, its a blob |
hi @sapraaman sorry about that, i just realized, that URL thing only happens if you attach an image using the paperclip button. you can see it http://gv-stage.dev.colab.coop/projects/48 under the "test" pad |
Ya see it @connieimdialog , but I don't think it applies to us because there is no url of the image when we generate it from DOM. Should I spend some more time on this trying to debug how to build HTML by modifying ep_copy_paste_images plugin ? |
ok, so, get this @sapraaman -- if you export the HTML the other way -- by clicking on the "Export" button on the tool bar, you will see an HTML downloaded with an included image. but the source code looks like .. crazy. unless the above helps somehow, let's just hold on this |
Thats not so crazy @connieimdialog, the crazy code is actually image blob. Scott told me that we added "Export" button because the other export was not working. So wait, isn't "Export" button enough for us, when the only reason we have "Export" button is that arrow button was not working while exporting images ? |
@shrutimehta13 same comments as #6 . Also, there are 2 ways to export to HTML. It would work one way and not the other. If you try to insert an image, and export it to html, and then try to add mc image and export it to html, both should have similar output in html - one method would work and the other would not. |
@sapraaman i see two buttons using this always disabled state Export button (separate bug?)- MC word image shows up in html @CrisNelson if this is the expected behaviour, we can close the ticket |
related to #10
Observed:
Media cloud word images do not appear in the html
The text was updated successfully, but these errors were encountered: