Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to implement "generic astro image API" with ipyastroimage #1

Open
eteq opened this issue Nov 29, 2018 · 3 comments
Open

Try to implement "generic astro image API" with ipyastroimage #1

eteq opened this issue Nov 29, 2018 · 3 comments

Comments

@eteq
Copy link

eteq commented Nov 29, 2018

As part of some work trying to build a python-friendly API for image viewers, I built this "concept" document:
https://gist.github.com/eteq/bb625148969db51b2b03b71e92ca5231

It would be an interesting experiment to see if this image viewer can meet that API. The target case I had in mind with this was indeed notebooks, so this might be a perfect simple test case for it...?

cc @mwcraig @maartenbreddels

@mwcraig
Copy link
Contributor

mwcraig commented Nov 29, 2018

On my list for sprinting next week 😀. This is mostly javascript and acts as a drop-in replacement for the Image mark in bqplot. I had started trying to work up a bqplot-based version of the image viewer over the summer but the default Image in bqplot is a little limited, and it can take a while for PRs to get reviewed and merged.

My understanding from a conversation on slack earlier this summer with @astrofrog is that this (ipyastroimage) will be used as part of glue-jupyter but that they don't intend to wrap it in a separate API for standalone use.

@maartenbreddels kept this piece of the glue-jupyter project separate from the rest of the glue repository so that we can use it in astrowidgets with minimal dependencies.

@maartenbreddels
Copy link
Collaborator

On my list for sprinting next week 😀

Let me know which days, happy to stand by to help.

and it can take a while for PRs to get reviewed and merged.

Yes, and I think also it makes more sense to be outside of bqplot so we can move faster, break the api when needed and put in really astro specific parts (do I hear WCS?).

will be used as part of glue-jupyter but that they don't intend to wrap it in a separate API for standalone use.

First part yes, second part is up to you/@astrofrog I think. It could be that the API as suggested by @eteq lives outside the repo, and this repo only provides the minimum required to make that happen. On the other hand it may be too scattered, and live in this repo as well. I think it's better for @astrofrog to decide on that part.

I personally would not mind this repo to move or merge, the main reason this Image mark is here is so we can move faster.

@pllim
Copy link
Contributor

pllim commented Jan 29, 2021

Did this go anywhere? I am revisiting the idea with HeatMap (because I forgot this repo existed) but I find that the mouse hover/click events are not giving me cursor info.

xref astropy/astrowidgets#72 and astropy/astrowidgets#121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants