Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Name of macOS pkg files always end with "-1.0.0.pkg" #1272

Open
SaptarshiSarkar12 opened this issue Aug 29, 2024 · 2 comments
Open

Bug: Name of macOS pkg files always end with "-1.0.0.pkg" #1272

SaptarshiSarkar12 opened this issue Aug 29, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@SaptarshiSarkar12
Copy link

Expected Behavior

The name of the generated macOS pkg file must end with the version number from the pom file. This would help to remove confusion over the version associated with that pkg file. Moreover, I do not think the use of 1.0.0 as the version number for naming purposes should be used always. It can be set as the default one instead, if no version is available.

Current Behavior

The generated pkg file always have the name {appName}-1.0.0.pkg.

Steps to Reproduce

  1. Build the macOS pkg file by running gluonfx:build and gluonfx:package.
  2. Check the filename of the target/gluonfx/aarch64-darwin/{appName}-1.0.0.pkg file.

Your Environment

Here's the link to the latest workflow run: https://github.com/SaptarshiSarkar12/Drifty/actions/runs/10611350063/job/29410704268#step:15:3710

Additional Information

I have figured out that the cause of this issue primarily lies in this code 👇

Logger.logDebug("Building final pkg");
Path finalPkg = paths.getAppPath().resolve(appName + "-1.0.0.pkg");

The version 1.0.0 is hardcoded in the name of the pkg file.
I would like to work on this issue if the maintainers want to fix this bug.

@SaptarshiSarkar12 SaptarshiSarkar12 added the bug Something isn't working label Aug 29, 2024
@SaptarshiSarkar12
Copy link
Author

@jperedadnr Please look into this issue once.

@SaptarshiSarkar12
Copy link
Author

@abhinayagarwal I request you to take a look into this issue 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant