You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The name of the generated macOS pkg file must end with the version number from the pom file. This would help to remove confusion over the version associated with that pkg file. Moreover, I do not think the use of 1.0.0 as the version number for naming purposes should be used always. It can be set as the default one instead, if no version is available.
Current Behavior
The generated pkg file always have the name {appName}-1.0.0.pkg.
Steps to Reproduce
Build the macOS pkg file by running gluonfx:build and gluonfx:package.
Check the filename of the target/gluonfx/aarch64-darwin/{appName}-1.0.0.pkg file.
Expected Behavior
The name of the generated macOS pkg file must end with the version number from the pom file. This would help to remove confusion over the version associated with that pkg file. Moreover, I do not think the use of 1.0.0 as the version number for naming purposes should be used always. It can be set as the default one instead, if no version is available.
Current Behavior
The generated pkg file always have the name
{appName}-1.0.0.pkg
.Steps to Reproduce
gluonfx:build
andgluonfx:package
.target/gluonfx/aarch64-darwin/{appName}-1.0.0.pkg
file.Your Environment
1.0.23
.Here's the link to the latest workflow run: https://github.com/SaptarshiSarkar12/Drifty/actions/runs/10611350063/job/29410704268#step:15:3710
Additional Information
I have figured out that the cause of this issue primarily lies in this code 👇
substrate/src/main/java/com/gluonhq/substrate/util/macos/Packager.java
Lines 222 to 223 in 0004727
The version
1.0.0
is hardcoded in the name of the pkg file.I would like to work on this issue if the maintainers want to fix this bug.
The text was updated successfully, but these errors were encountered: