setting closurePath

[charleshross]

if 'closurePath' is a direct filepath to the closure jar file you should make it so it can use that instead of concatenating /build/compiler.jar at the end all the time.

[langdonx]

+1

[mr-moon]

+1

[langdonx]

I saw this, but I don't think it's a very good solution:

• add ability to point directly to .jar file #36

A think a better solution would be...

• if file exists closurePath (file exists, not directory), use it
• else if file exists closurePath + "/compiler.jar", use it
• else if file exists closurePath + "/build/compiler.jar", use it
• else throw an error

[software-engineering]

+1

[jhaoda]

+1

[quantuminformation]

+1

[gmarty]

I agree the current situation is not ideal. The best approach would be to ship grunt-closure-compiler with Closure Compiler. So maybe something like a global npm install that would download Closure Compiler and the externs definition files once for all.
I don't really have time to work on that at the moment, but I'm happy to accept PR.

[ChadKillingsworth]

👍

[ChadKillingsworth]

@gmarty Closure compiler is now officially published to npm. Perhaps the compiler should be listed as a node peer dependency? That would allow users to control the version of the compiler separately from the grunt plugin.

https://www.npmjs.com/package/google-closure-compiler

[ChadKillingsworth]

Apparently peerDependencies are being deprecated, so that option probably isn't the best.

[mandrews]

+1

[ChadKillingsworth]

The official distribution of closure-compiler has a grunt and gulp plugin included.