Skip to content
This repository has been archived by the owner on Nov 19, 2023. It is now read-only.

Support for Node >= 4 ? #45

Closed
daniloisr opened this issue Nov 2, 2018 · 2 comments
Closed

Support for Node >= 4 ? #45

daniloisr opened this issue Nov 2, 2018 · 2 comments
Labels

Comments

@daniloisr
Copy link

Hello, from the Release Notes we have:

1.0.01: added support for older nodejs versions (4,6,7) using internal copy of [email protected]

But it's not working for me on both Node 4 and 5:

SyntaxError: Unexpected token = at exports.runInThisContext (vm.js:53:16)

You can check the code I'm doing here: MiniProfiler/node#7

I tried to fix this but without success yet, seems that the problem is in the TSC option "module": "commonjs".

Any tip on how I can make this work?
Thanks

@gms1 gms1 added the bug label Nov 2, 2018
@gms1
Copy link
Owner

gms1 commented Nov 2, 2018

hm, the nodejs <8 support was completely missing, apparently no one else needs this, but this has been fixed now:
https://travis-ci.org/gms1/node-async-context/builds/449982193

I will probably create and publish a 1.1.x branch for nodejs 4-11 and a 2.0.x branch for nodejs >=8 only tomorrow

gms1 added a commit that referenced this issue Nov 2, 2018
@gms1
Copy link
Owner

gms1 commented Nov 2, 2018

fixed in 1.1.0; please use asyncctx@<2.0 in package.json

@gms1 gms1 closed this as completed Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants