Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Maintainer #32

Open
geoffgarside opened this issue May 12, 2019 · 4 comments
Open

New Maintainer #32

geoffgarside opened this issue May 12, 2019 · 4 comments

Comments

@geoffgarside
Copy link
Contributor

@bbiao has volunteered to take over maintainership. Member access to the go-cas organisation has been granted.

@geoffgarside geoffgarside pinned this issue May 12, 2019
@finalthink
Copy link

@bbiao Hi.

Why don't you merge the pull request from other developers?

If you wanna this cas lib keep alive, but you don't have time, you can give the maintainership to another one. @geoffgarside @bbiao

@bbiao
Copy link
Contributor

bbiao commented Jan 22, 2021

@bbiao Hi.

Why don't you merge the pull request from other developers?

If you wanna this cas lib keep alive, but you don't have time, you can give the maintainership to another one. @geoffgarside @bbiao

I'm very sorry for that. It's been very busy in 2020. I will make sure the pr will be reviewed and merged in the following days.

@xczh
Copy link

xczh commented Mar 2, 2021

Is this project still under active maintenance? It seems that a lot of the code was modified five or six years ago.

I think the following improvements should be done at least:

  • Remove glog external log library dependency
  • The client has not fully implemented the description of CAS protocol version 2.0 and 3.0. I suggest that according to the protocol text, refer to the Java version of the client implementation, re comb and improve the implementation details
  • Rearrange the code and file structure if necessary. This may seem like a disruptive change, so you can consider developing it on v3.0

@bbiao Do you have time for these jobs? I noticed that the go-cas organization does not have any public members. The number of users is continuously losing. Maybe we can consider absorbing some public members to jointly maintain the project, so as to maintain the activity of the project development.

@bbiao bbiao unpinned this issue Mar 2, 2021
@bbiao
Copy link
Contributor

bbiao commented Mar 3, 2021

@xczh thanks for your suggestion and I appreciate anyone who want to contribute to this project.

Since I am not very familiar the github organization system, I need sometime to learn how to add public members.

As mentioned in issue #26, I think the work will be done in the following week.

And after that, we can discuss how to start a new v3 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants