Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompilationDatabase_Error is an error and should be the last return argument #122

Open
zimmski opened this issue Sep 8, 2016 · 0 comments

Comments

@zimmski
Copy link
Member

zimmski commented Sep 8, 2016

FromDirectory has an return argument of type CompilationDatabase_Error which should be the last argument because it is an error and the Go idiom is to put errors last, even if they are user defined types.

Look through all version repositories if there are more instances of this kind of API inconsistency, e.g. LoadDiag_Error was easy to find

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant