Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url_launcher plugin broken #642

Open
provokateurin opened this issue Feb 21, 2022 · 5 comments
Open

url_launcher plugin broken #642

provokateurin opened this issue Feb 21, 2022 · 5 comments
Assignees

Comments

@provokateurin
Copy link
Member

This PR breaks the go-flutter url_launcher plugin implementation completely.

@pchampio
Copy link
Member

pchampio commented Feb 21, 2022

What should we do?
I/We cannot keep up with the pace at which google is pushing modification. Sadly this one is a breaking one.
I haven't looked at the how native plugin implementation works, it might actually be easier than the current method-channel-based one as it seems to call native code directly from dart without calling the embedder.
TODO: add dart ffi native plugin support.


Edit 13/05/2022
I've side track a bit.
The issue was not about dart ffi, but about the modification of channel names.

# before
"plugins.flutter.io/url_launcher",
# after
"plugins.flutter.io/url_launcher_macos",
"plugins.flutter.io/url_launcher_windows",
"plugins.flutter.io/url_launcher_linux",

fixed in go-flutter-desktop/plugins#74

@provokateurin
Copy link
Member Author

TBH except for packaging to mac and linux the official embedder has become superior :( I already talked with @GeertJohan about maybe extracting the packaging code and making a separate tool for just packaging flutter desktop apps.

@pchampio
Copy link
Member

pchampio commented Feb 21, 2022

I'm not supporting adding new feature/refactoring parts of the go-flutter project.
The core functionality of go-flutter project still works, even though many features have been added to Flutter. I'm happy with the current state. For a non-official embedder, it's sufficient.

Having the official embedder become superior was just a question of time.

Our software is good. The use of golang is an excellent way of writing plugins.
But it only is interesting for a small set of users. For the majority, the official embedder will always be better.

@niuhuan
Copy link

niuhuan commented Mar 8, 2022

I tried to fix it, did some simple test on my MacOS , it did works.
go-flutter-desktop/plugins#74

@stuartmorgan
Copy link

What should we do?
I/We cannot keep up with the pace at which google is pushing modification. Sadly this one is a breaking one.

FYI this is a Flutter bug: flutter/flutter#103660

Changes like the one referenced above were supposed to have no effect on custom embeddings like this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants