Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional Prometheus metrics #17653

Closed
laurivosandi opened this issue Nov 15, 2021 · 2 comments
Closed

Add additional Prometheus metrics #17653

laurivosandi opened this issue Nov 15, 2021 · 2 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@laurivosandi
Copy link

laurivosandi commented Nov 15, 2021 •
edited
Loading

Feature Description

It's great that people are aware of Prometheus, but what is the usefulness of metrics added in #678 ?
Realistically these can't be used for alerting.

How about we add some actually useful metrics:

  • Successful/failed SSH login attempts
  • Successful/failed login attempts via web
  • Currently open TCP connections (recently our Gitea gets hammered by DDoS attacks)
  • HTTP response latency histogram
  • Errors encountered while interacting with Git repos
  • Failed/successful webhook calls

These were just few to mention. Some of these can be handled by haproxy that sits in front of Gitea which is the case for us of course...

Screenshots

No response
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Nov 16, 2021
@techknowlogick techknowlogick changed the title Add actually useful Prometheus metrics Add additional Prometheus metrics Nov 18, 2021
@laurivosandi laurivosandi mentioned this issue Aug 25, 2023
Open
@laurivosandi
Copy link
Author

If I am reading right Gitea uses Chi framework so enabling some of those metrics is trivial simply by adding, just make sure no high entropy labels are included: https://pkg.go.dev/github.com/m8as/go-chi-metrics

@laurivosandi laurivosandi mentioned this issue Aug 25, 2023
Open
@rremer rremer mentioned this issue Oct 31, 2024
Open
6 tasks
@lunny
Copy link
Member

lunny commented Nov 1, 2024

Merged into #14724

@lunny lunny closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lunny @laurivosandi