Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The PRs link in release page will get network error #31161

Open
yp05327 opened this issue May 29, 2024 · 5 comments · May be fixed by #31181
Open

The PRs link in release page will get network error #31161

yp05327 opened this issue May 29, 2024 · 5 comments · May be fixed by #31181
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@yp05327
Copy link
Contributor

yp05327 commented May 29, 2024

Description

IMG_2701
https://gitea.com/gitea/act_runner/releases

I will check it later. Not sure whether this is a bug now.

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

gitea.com

Database

None

@silverwind
Copy link
Member

Does not reproduce for me:

image

@yp05327
Copy link
Contributor Author

yp05327 commented May 29, 2024

I did this on mobile. On mobile, there's no way to display this tooltips unless you click it.
But if you click it, it will go to the PR's page. And when you back to this page, you will see network error.
So I did two things together: show the tooltips (a bit faster) and go to the PR's page.
So for mobile view, maybe we need to allow user click a URL to show the tooltip at the first time if it has a tooltip, then the second time the click will go to the target link.

@silverwind
Copy link
Member

silverwind commented May 30, 2024

I can follow. When you click a link, it starts loading, but aborts because the page unloads. When you hit the back button, you get a cached page from bfcache which apparently also caches the error popup.

As for solutions, I think we could try to cancel the request before page unload and not show a error in such a case.

@yp05327
Copy link
Contributor Author

yp05327 commented May 30, 2024

When you click a link, it starts loading, but aborts because the page unloads.

Yes, that's it. 👍

@yp05327 yp05327 added the topic/ui Change the appearance of the Gitea UI label May 30, 2024
@silverwind
Copy link
Member

#31181 will fix this and other problems with that popup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants