This repository has been archived by the owner on Jun 8, 2019. It is now read-only.
forked from gogs/go-gogs-client
-
Notifications
You must be signed in to change notification settings - Fork 53
ListPullRequestsOptions does not work? #162
Open
quantonganh
wants to merge
7
commits into
go-gitea:master
Choose a base branch
from
quantonganh:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How can I make the test passed if there are some dependencies in my code? https://drone.gitea.io/go-gitea/go-sdk/152/1/2 |
@lunny Could you please review this before I update other files? |
lunny
suggested changes
Apr 19, 2019
gitea/gitea.go
Outdated
u.RawPath = "/api/v1" + path | ||
u.Path = "/api/v1" + unescaped | ||
|
||
if body != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only if method is GET
to do that.
} | ||
|
||
if method == "POST" || method == "PUT" { | ||
bodyBytes, err := json.Marshal(body) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The body has been read to end on above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please explain?
Please resolve the conflicts. |
quantonganh
force-pushed
the
master
branch
5 times, most recently
from
May 17, 2019 16:34
4e11e49
to
3d21a91
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #161