Skip to content
This repository has been archived by the owner on Jun 8, 2019. It is now read-only.

ListPullRequestsOptions does not work? #162

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

quantonganh
Copy link

Fix #161

@quantonganh
Copy link
Author

How can I make the test passed if there are some dependencies in my code? https://drone.gitea.io/go-gitea/go-sdk/152/1/2

@quantonganh
Copy link
Author

@lunny Could you please review this before I update other files?

gitea/gitea.go Outdated
u.RawPath = "/api/v1" + path
u.Path = "/api/v1" + unescaped

if body != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if method is GET to do that.

}

if method == "POST" || method == "PUT" {
bodyBytes, err := json.Marshal(body)
Copy link
Member

@lunny lunny Apr 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The body has been read to end on above.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain?

@lunny
Copy link
Member

lunny commented May 16, 2019

Please resolve the conflicts.

@quantonganh quantonganh force-pushed the master branch 5 times, most recently from 4e11e49 to 3d21a91 Compare May 17, 2019 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListPullRequestsOptions does not work?
3 participants