Can we apply the gamepad issue fix before 3.3.5 is released?

[hajimehoshi]

Now GLFW 3.3 has an issue that specific gamepads crashes the app immediately, and this will be fixed in 3.3.5 (glfw/glfw#1763). This is a pretty serious problem in my library that uses GLFW (e.g. hajimehoshi/ebiten#1229). As we're not sure when 3.3.5 is released, would it be possible to apply the patch before 3.3.5 is released?

CC @dmitshur

[dmitshur]

Given it is a serious issue, I think "backporting" the GLFW (C library) fix for it in go-glfw would be reasonable to do. It looks like a small patch that just removes those lines that send GLFW_INVALID_VALUE.

In this particular case, we can also consider applying a temporary workaround on the side of go-glfw. That is, to modify glfw.Init to accept GLFW_INVALID_VALUE as well until GLFW 3.3.5 is released and go-glfw updates to using it. Perhaps that's easier, since we'd only need to change Go code.

We should keep issue #292 open until this is fully resolved and workarounds are removed.

[hajimehoshi]

Thanks.

Now invalidValue is an error that should not be handled in go-gl/glfw. Can we change this to be handleable?

EDIT: NVM, acceptError can take invalidError.

[hajimehoshi]

hajimehoshi/ebiten#1229 (comment)

It looks like we also need to fix PollEvents.

I've already reported this issue at the original GLFW issue (glfw/glfw#1763 (comment))