New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review tests on Windows #11

Open

christian-korneck opened this issue Jun 3, 2022 · 2 comments

Labels

bug enhancement

Collaborator

christian-korneck commented Jun 3, 2022

some tests aren't working on Windows, probably never have.

christian-korneck added bug enhancement labels

RolandMa1986 commented Aug 5, 2022 •

edited

Loading

Hi @christian-korneck,

I found 3 issues when running test ong windows. But I'm not sure whether it's a environment or os specific for the first two issues.

getvalue method can't be found on windows

cpy3/high_level_layer_test.go

Line 19 in 8f74340

result := stdout.CallMethodArgs("getvalue")
I got a PyExc_KeyboardInterrupt which don't match PyExc_TypeError.

cpy3/errors_test.go

Line 250 in 8f74340

assert.True(t, PyErr_GivenExceptionMatches(exc, PyExc_TypeError))
File path is diffrent. This issue can be fixed by trim "/"

cpy3/module_test.go

Line 110 in 8f74340

assert.True(t, strings.HasSuffix(filename, "/queue.py"))

Collaborator Author

christian-korneck commented Aug 5, 2022

thanks, would love to see PRs to fix these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment