Handling of CMD_ID, CMD_CAP

[AlexNCoder]

Handling of CMD_ID, CMD_CAP

Hello everyone! I found that CMD_ID handling on PD is insufficient, maybe (func pd_decode_command, case CMD_ID). It sets ret to OSDP_PD_ERR_GENERIC when osdp-message from the CP (physical device, not libosdp) can be without data-bytes. By the way, real card reader (physical device) can handle such messages. Am I wrong?

Maybe we can change that condition from “if (len != CMD_ID_DATA_LEN)” to “if (len > CMD_ID_DATA_LEN)”
It's all the same about CMD_CAP ?

I've created a pull request

[sidcha]

[..] when osdp-message from the CP (physical device, not libosdp) can be without data-bytes.

What makes you think so? Can you cite the specification please.

By the way, real card reader (physical device) can handle such messages.

Not sure what you mean by "real" card reader here.. I thought they were all real :)