Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused strhelper functions #446

Open
goatshriek opened this issue Sep 26, 2024 · 1 comment
Open

remove unused strhelper functions #446

goatshriek opened this issue Sep 26, 2024 · 1 comment
Assignees
@Brijeshthummar02
Labels
good first issue something that would be simple for a newcomer to stumpless to work on help wanted external contributations encouraged low code work that requires little to no coding proficiency refactor changes that require refactoring of existing code

Comments

@goatshriek
Copy link
Owner

The src/strhelper.c file has two functions, copy_cstring_length and to_upper_case that are no longer used. Remove these functions from the source file, associated header file include/private/strhelper.h, and header manifest in tools/check_headers/stumpless.yml. Of course, make sure that all builds and testing continue to succeed.
@goatshriek goatshriek added help wanted external contributations encouraged good first issue something that would be simple for a newcomer to stumpless to work on refactor changes that require refactoring of existing code low code work that requires little to no coding proficiency hacktoberfest labels Sep 26, 2024
@Brijeshthummar02
Copy link

i would like to work on this.

@Brijeshthummar02 Brijeshthummar02 mentioned this issue Sep 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brijeshthummar02 Brijeshthummar02

Labels
good first issue something that would be simple for a newcomer to stumpless to work on help wanted external contributations encouraged low code work that requires little to no coding proficiency refactor changes that require refactoring of existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goatshriek @Brijeshthummar02