Error on must-relocking of non-recursive mutex #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayLocks analysis can warn on it, but mutex analysis can be definite about it.
michael-schwarz
approved these changes
Nov 23, 2024
|
I ran it on our regression suite and found a couple of such typos as well. Apparently e141caf fixed some a long time ago, but without actually having an analysis for it for all this time. |
…to TODO On MacOS the mutex type is top because it's zero-initialized global. On MacOS zero-initialized mutex isn't the same as a default mutex (type 0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mayLocks analysis can warn on it, but mutex analysis can be definite about it.
Inspired by https://gitlab.com/sosy-lab/benchmarking/sv-benchmarks/-/merge_requests/1587 which we clearly have the information for, but didn't say anything.
We cannot go to dead code in this case because we don't distinguish error-checking mutexes.