Skip to content

Commit e238ff1

Browse files
Remove resource leak issue from REMEDIATION.md
This issue has been fixed in PR #1448, so removing it from the remediation document as requested. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 09b6ba0 commit e238ff1

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

go/appencryption/REMEDIATION.md

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -42,25 +42,6 @@ _ = err // err is intentionally ignored
4242
- Add metrics/monitoring for metastore failures
4343
- Implement error classification (retriable vs permanent)
4444

45-
### 2. Resource Leak on Close Error
46-
**Location**: `session.go:99-100`
47-
```go
48-
if f.Config.Policy.SharedIntermediateKeyCache {
49-
f.intermediateKeys.Close()
50-
}
51-
return f.systemKeys.Close()
52-
```
53-
54-
**Why Fix**:
55-
- First Close() error is lost if second fails
56-
- Leaves resources (memory, file handles) leaked
57-
- In long-running services, accumulates resource leaks
58-
- Makes it hard to diagnose which component failed
59-
60-
**Remediation**:
61-
- Collect all errors using `multierr` or similar
62-
- Ensure all resources are attempted to be closed
63-
- Return combined error with full context
6445

6546
## Priority Order for Remediation
6647

@@ -69,7 +50,6 @@ return f.systemKeys.Close()
6950

7051
2. **Lower Priority (Observability)**:
7152
- Silent error swallowing (Other #1)
72-
- Resource leak on close error (Other #2)
7353

7454
## Testing Recommendations
7555

0 commit comments

Comments
 (0)