Skip to content

Commit 16301df

Browse files
authored
chore(eslint)!: migrate all eslint configs to v9 (#974)
* chore(eslint)!: migrate eslint-config-godaddy to v9 BREAKING CHANGE: This removes v8 from being supported and moves to flat config * chore(flow)!: remove flow config as no longer supported * chore(eslint)!: migrate godaddy-react to v9 BREAKING CHANGE: This removes eslint@v8 from support and moves to flat config * chore(eslint)!: migrate godaddy-react-typescript to v9 BREAKING CHANGE: This removes eslint@v8 from support and moves to flat config * chore(eslint)!: migrate godaddy-typescript to v9 BREAKING CHANGE: This removes eslint@v8 from support and moves to flat config * chore(changeset) add changeset for major bump * chore: address comments * doc: update READMEs * chore: update changsets despcription * chore(pkg): update package.jsons
1 parent ee495d1 commit 16301df

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+2115
-2293
lines changed

.changeset/blue-rats-notice.md

+10
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
---
2+
"eslint-config-godaddy-react-typescript": major
3+
"eslint-config-godaddy-typescript": major
4+
"eslint-config-godaddy-react": major
5+
"eslint-config-godaddy": major
6+
---
7+
8+
chore(eslint)!: migrate all eslint configs to eslint@v9
9+
10+
BREAKING CHANGE: removes v8 support and transistions configs to flat config. Also these packages are now `type:module`

.eslintrc.js eslint.config.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
module.exports = {
2-
extends: './packages/eslint-config-godaddy/index.js',
1+
import gdConfig from "./packages/eslint-config-godaddy/index.js";
2+
3+
export default {
4+
...gdConfig,
35
rules: {
46
//
57
// This is used for both ES5 and ES6 config filesso we simply

package-lock.json

+1,685-1,326
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+11-6
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
"version": "6.0.0",
44
"private": true,
55
"description": "The approach to JavaScript at GoDaddy. We think it's pretty decent.",
6+
"type": "module",
67
"engines": {
78
"node": ">=22",
89
"npm": ">=10"
@@ -47,16 +48,20 @@
4748
"godaddy-js-style-eslint": "./bin/eslint"
4849
},
4950
"devDependencies": {
50-
"@changesets/cli": "^2.27.9",
51-
"eslint": "^8.57.1",
52-
"eslint-plugin-json": "^3.1.0",
51+
"@changesets/cli": "^2.27.11",
52+
"@eslint/eslintrc": "^3.2.0",
53+
"@eslint/js": "^9.17.0",
54+
"@typescript-eslint/eslint-plugin": "^8.18.1",
55+
"@typescript-eslint/parser": "^8.18.1",
56+
"eslint": "^9.17.0",
57+
"eslint-plugin-json": "^4.0.1",
5358
"eslint-plugin-jsx-a11y": "^6.10.2",
5459
"eslint-plugin-mocha": "^10.5.0",
5560
"eslint-plugin-react": "^7.37.2",
56-
"react": "^17.0.2",
57-
"rimraf": "^3.0.2",
61+
"react": "^19.0.0",
62+
"rimraf": "^6.0.1",
5863
"turbo": "^1.13.4",
59-
"typescript": "^4.9.5"
64+
"typescript": "^5.7.2"
6065
},
6166
"workspaces": [
6267
"packages/*"

packages/eslint-config-godaddy-flow/.eslintrc

-3
This file was deleted.

packages/eslint-config-godaddy-flow/.npmignore

-2
This file was deleted.

packages/eslint-config-godaddy-flow/CHANGELOG.md

-41
This file was deleted.

packages/eslint-config-godaddy-flow/README.md

-55
This file was deleted.

packages/eslint-config-godaddy-flow/bin/eslint-godaddy-flow

-4
This file was deleted.

packages/eslint-config-godaddy-flow/extends.js

-17
This file was deleted.

packages/eslint-config-godaddy-flow/index.js

-24
This file was deleted.

packages/eslint-config-godaddy-flow/package.json

-43
This file was deleted.

packages/eslint-config-godaddy-react-flow/.eslintrc

-3
This file was deleted.

packages/eslint-config-godaddy-react-flow/.npmignore

-2
This file was deleted.

packages/eslint-config-godaddy-react-flow/CHANGELOG.md

-41
This file was deleted.

packages/eslint-config-godaddy-react-flow/README.md

-55
This file was deleted.

packages/eslint-config-godaddy-react-flow/bin/eslint-godaddy-react-flow

-4
This file was deleted.

packages/eslint-config-godaddy-react-flow/extends.js

-17
This file was deleted.

0 commit comments

Comments
 (0)