Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy for contributing more plugins #10

Open
extrawurst opened this issue Apr 23, 2021 · 6 comments
Open

Policy for contributing more plugins #10

extrawurst opened this issue Apr 23, 2021 · 6 comments

Comments

@extrawurst
Copy link

I wrote a plugin now that allows access to iOS native api UIImpactFeedbackGenerator (nicer haptics than regular vibration). I was wondering whether this might be something worth adding to the official plugins repo since it is only giving access to iOS native API and no third party stuff.

if this is welcomed I can make it a PR.

@naithar
Copy link
Contributor

naithar commented Apr 23, 2021

@akien-mga I think we should come up with some way to include new plugins into this repo, but I'm not really sure how to make it work.

@akien-mga akien-mga changed the title policy for contributing more plugins Policy for contributing more plugins Apr 23, 2021
@akien-mga
Copy link
Contributor

It's mostly up to you as maintainer, but IMO we can add more first-party plugins here which give access to native iOS APIs, as long as the implementation seems easy enough to maintain. We can also aim to grow the team of maintainers of iOS plugins here to ensure that it's manageable.

Plugins for third-party APIs should likely stay separate and distributed via community repositories.

@extrawurst
Copy link
Author

btw. I put the plugin now in a GitHub repo, we can migrate it whenever we want: https://github.com/extrawurst/godot-ios-impact-plugin

@naithar
Copy link
Contributor

naithar commented Apr 24, 2021

@akien-mga got it, thanks :)

@extrawurst I'll wait for your PR then. And don't forget to modify SConstruct and release scripts to support new plugin.

@extrawurst
Copy link
Author

@naithar I have a question though, where do I need to add documentation for whatever api I am adding? can't find that in here.

@naithar
Copy link
Contributor

naithar commented Apr 24, 2021

For now every plugin has it's own README file with description and API, ex: https://github.com/godotengine/godot-ios-plugins/blob/master/plugins/apn/README.md. But if you have any idea how to make it work better, I'm open to suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants