Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Undo / Redo support to Animation Library Editing #10062

Closed
Arnklit opened this issue Jun 28, 2024 · 5 comments · Fixed by godotengine/godot#93898
Closed

Add Undo / Redo support to Animation Library Editing #10062

Arnklit opened this issue Jun 28, 2024 · 5 comments · Fixed by godotengine/godot#93898

Comments

@Arnklit
Copy link

Arnklit commented Jun 28, 2024

Describe the project you are working on

A game in production

Describe the problem or limitation you are having in your project

When editing animation libraries it is easy to make a mistake and loose work due to it not supporting undo redo.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Implement undo / redo in the Animation Library

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

You should be able to undo deleting / creating / renaming / copying animations in the "Edit Animations Libraries" view.
image

If this enhancement will not be used often, can it be worked around with a few lines of script?

Undo / Redo missing cannot be worked around with a script

Is there a reason why this should be core and not an add-on in the asset library?

This is about improving the editor workflow out of the box

@AThousandShips
Copy link
Member

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Please fill this in in more detail, what options are we talking about and how would this work?

@Arnklit
Copy link
Author

Arnklit commented Jun 28, 2024

Please fill this in in more detail, what options are we talking about and how would this work?

Sorry. Good point. I added a basic description, but maybe this would make more sense as a Discussion issue.

@AThousandShips
Copy link
Member

Generally proposals should have some basic description or idea of how to do it as well as what to do, but this might be sufficient

@akien-mga
Copy link
Member

There is UndoRedo code in AnimationLibraryEditor, so this might be a bug more than a missing feature.
CC @KoBeWi

@KoBeWi
Copy link
Member

KoBeWi commented Jul 3, 2024

Yes, the code exists, and it's functional, but the undo/redo shortcuts don't work while the dialog is open. You need to close it first 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants