-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Godot4.4-dev5: ClassDB
provides classes AnimationNodeStartState and AnimationNodeEndStatewhere which are not registered
#99534
Comments
ClassDB
provides classes where not exists/accessibleClassDB
provides classes AnimationNodeStartState and AnimationNodeEndStatewhere which are not registered
CC @TokageItLab @RandomShaper, see also #98963 which registered those classes as internal. |
They are "currently" only used to make decisions to prevent editing, so I believe they can actually be replaced by the AnimationNode. However, they will need to be exposed again in the future when we allow additional ports (see also #88878 (comment)), but until then they are not necessary. |
I feel like this indicates a bug somewhere. These classes are registered via UPDATE: Did a little more poking around! Internally, we use But, for the public |
…ernal, this triggers a ClassDB bug Fixes godotengine#99534.
…ernal, this triggers a ClassDB bug Fixes godotengine#99534.
I've spent a little more time digging into this, and I've gone in circles a little bit. :-) The main question is: do we want Because currently:
So, these are the two options:
I think option nr 1 is the cleanest, so long as that change doesn't break anything. It would have no impact on GDExtension (I was wrong about what I wrote above), because classes that aren't exposed already can't be used from GDExtension (aside from the same Here's PR #102440 that implements option nr 1 If PR #102433 is enough to fix this for all classes that exist at the moment, we should go with that for Godot 4.4. And, if no one thinks of a case that my PR would break, we can try that early in Godot 4.5's dev. |
Tested versions
v4.4.dev5.mono.official [9e60984]
System information
all
Issue description
I iterate over all classes provided by
ClassDB
for testing. UsingClassDB:get_class_list()
With Godot4.4.dev5 there is now “AnimationNodeStartState”, “AnimationNodeEndState” there are not documented and cannot be instantiated.
Steps to reproduce
Can be verified by
output:
errors:
Minimal reproduction project (MRP)
n/a
The text was updated successfully, but these errors were encountered: