Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to close Godot with two or more scenes with changes open can lock the engine #102418

Open
matheusmdx opened this issue Feb 4, 2025 · 1 comment · May be fixed by #102444
Open

Attempt to close Godot with two or more scenes with changes open can lock the engine #102418

matheusmdx opened this issue Feb 4, 2025 · 1 comment · May be fixed by #102444

Comments

@matheusmdx
Copy link
Contributor

Tested versions

  • Reproducible in latest master (eee39f0)
  • Not reproducible in 4.4 beta 2

System information

Godot v4.4.beta (eee39f0) - Windows 10 (build 19045) - Multi-window, 2 monitors - Vulkan (Forward+) - dedicated AMD Radeon RX 580 2048SP (Advanced Micro Devices, Inc.; 31.0.21921.1000) - AMD Ryzen 5 3600 6-Core Processor (12 threads)

Issue description

When you have two or more scenes open with unsaved changes and attempt to close the editor, selecting Don't save lock the engine from be closed or restarted.

After select Don't save these three errors will appear:

ERROR: Can't add child '@ConfirmationDialog@8238' to itself.
   at: (C:\Users\Matheus\Downloads\Godot Source\scene/main/node.cpp:1652)
ERROR: Condition "!windows.has(p_window)" is true. Returning: -1
   at: DisplayServerWindows::window_get_current_screen (platform\windows\display_server_windows.cpp:1959)
ERROR: Condition "!is_inside_tree()" is true.
   at: Viewport::_push_unhandled_input_internal (C:\Users\Matheus\Downloads\Godot Source\scene/main/viewport.cpp:3338)

And any new attempt to close/restart the editor or close a scene will throw this error:

ERROR: Condition "!is_inside_tree()" is true.
   at: Window::popup_centered (C:\Users\Matheus\Downloads\Godot Source\scene/main/window.cpp:1794)
unknown_2025.02.04-12.58.mp4

Bisecting points to #102070 as the culprit

Image

CC @ryevdokimov

Steps to reproduce

  1. Open two scenes at the same time
  2. Do any modification in both scenes but don't save
  3. Try to close/restart the editor
  4. In the confirmation window, choice Don't save

Minimal reproduction project (MRP)

N/A

@ryevdokimov
Copy link
Contributor

ryevdokimov commented Feb 5, 2025

Fix above, nice find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Release Blocker
Development

Successfully merging a pull request may close this issue.

3 participants